mesa: bd326c229c528a214c9fda705e7a961cfa49ac9e (master 11.3.0-devel)
nir/nir_lower_double_packing.c:79:4: error: void function 'lower_double_pack_impl' should not return a value [-Wreturn-type]
Build error introduced by this commit.
Author: Jason Ekstrand <firstname.lastname@example.org>
Date: Wed Apr 13 16:26:57 2016 -0700
nir/lower_double_pack: fixup for new nir_foreach_block()
Signed-off-by: Jason Ekstrand <email@example.com>
Reviewed-by: Connor Abbott <firstname.lastname@example.org>
Reviewed-by: Ian Romanick <email@example.com>
GCC (at least 5.2.1) also throws an warning...
src/compiler/nir/nir_lower_double_packing.c: In function ‘lower_double_pack_impl’:
src/compiler/nir/nir_lower_double_packing.c:79:11: warning: ‘return’ with a value, in function returning void
Don't older GCC versions warn?
I've took the liberty of pushing fix 8ae78f7d2828778a386ed1737f17add69eb035a9
(In reply to Jose Fonseca from comment #1)
> GCC (at least 5.2.1) also throws an warning...
> src/compiler/nir/nir_lower_double_packing.c: In function
> src/compiler/nir/nir_lower_double_packing.c:79:11: warning: ‘return’ with a
> value, in function returning void
> return true;
> Don't older GCC versions warn?
> I've took the liberty of pushing fix 8ae78f7d2828778a386ed1737f17add69eb035a9
Thanks! Patch looks good to me.