Bug 95380 - [BAT various] basic-flip-vs-wf_vblank fails with unexpected frame count
Summary: [BAT various] basic-flip-vs-wf_vblank fails with unexpected frame count
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: DRI git
Hardware: x86-64 (AMD64) Linux (All)
: highest blocker
Assignee: cprigent
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-13 09:22 UTC by mwa
Modified: 2016-05-24 07:23 UTC (History)
1 user (show)

See Also:
i915 platform: BXT, KBL
i915 features: display/Other


Attachments
kbl-kms_flip-basic-flip-vs-wf_vblank-kern.log (227.91 KB, text/x-log)
2016-05-13 16:52 UTC, cprigent
no flags Details
kbl-output-kms_flip-basic-flip-vs-wf_vblank (6.33 KB, text/plain)
2016-05-13 16:52 UTC, cprigent
no flags Details

Description mwa 2016-05-13 09:22:21 UTC
(kms_flip:7848) CRITICAL: Test assertion failure function check_final_state, file kms_flip.c:1192:
(kms_flip:7848) CRITICAL: Failed assertion: count >= expected * 99/100 && count <= expected * 101/100
(kms_flip:7848) CRITICAL: Last errno: 25, Inappropriate ioctl for device
(kms_flip:7848) CRITICAL: dropped frames, expected 99, counted 100, encoder type 2
Subtest basic-flip-vs-wf_vblank failed.


Should hopefully get fixed by https://patchwork.freedesktop.org/patch/86358/
Comment 1 cprigent 2016-05-13 16:52:00 UTC
Created attachment 123707 [details]
kbl-kms_flip-basic-flip-vs-wf_vblank-kern.log

Also fail on our side:

Hardware
Platform: KABY LAKE-U
CPU : Intel(R) Core(TM) @ 2.60GHz
MCP : KBL-U G0 2+2 (ou ULT-G0)
QDF : QYQ8
Chipset PCH: SPT-LP C1
CRB : KABY LAKE U DDR3L RVP7 CRB FAB1

Software
BIOS : KBLSE2R1.R00.X015.B01.1511271314
ME FW : 11.5.0.1008
Ksc (EC FW): 1.20
Linux distribution: Ubuntu 16.04 64 bits
kernel drm-intel-nightly 4.6.0-rc7 61f856f from http://cgit.freedesktop.org/drm-intel/
  commit 61f856faa1e6ff9dddad214be1e372e8aacfc0f4
  Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
  Date:   Mon May 9 19:24:21 2016 +0300
  drm-intel-nightly: 2016y-05m-09d-16h-24m-01s UTC integration manifest
libdrm-2.4.68 fc09c5a from git://anongit.freedesktop.org/mesa/drm
cairo: 1.15.2 db8a7f1 from git://anongit.freedesktop.org/cairo
IGT 1.14 cc24755 from http://anongit.freedesktop.org/git/xorg/app/intel-gpu-tools.git
Comment 2 cprigent 2016-05-13 16:52:22 UTC
Created attachment 123708 [details]
kbl-output-kms_flip-basic-flip-vs-wf_vblank
Comment 3 Marius Vlad 2016-05-16 15:24:03 UTC
Should be fixed in master. Please test.

commit 5cc3175ca5a0374c17bd201ba5a35ef4ff076003
Author: Feceoru, Gabriel <gabriel.feceoru@intel.com>
Date:   Fri May 13 14:45:09 2016 +0300

    tests/kms_flip: Adjust tolerance when counting frames
    
    basic-flip-vs-wf_vblank subtest sometimes fails asserting counted frames to
    be aproximately equal with the estimated number.
    
    This is a false negative, one of the reasons being the precision lost when
    truncating a fractional number.
    
    Fixed this by using floating point arithmetic.
    
    Cc: Jani Nikula <jani.nikula@intel.com>
    Cc: Daniel Vetter <daniel.vetter@intel.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95380 [mvlad]
    Signed-off-by: Gabriel Feceoru <gabriel.feceoru@intel.com>
    Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
Comment 4 Kimmo Nikkanen 2016-05-16 18:19:43 UTC
Assigning to QA
Comment 5 Luis Botello 2016-05-23 23:10:43 UTC
Issue is not seen anymore over KBL-U with the following config:

 |=== Software information ===|

 ++ Kernel version                      : 4.6.0-nightly+
 ++ Linux distribution                  : Ubuntu 16.04 LTS
 ++ Architecture                        : 64-bit
 ++ xf86-video-intel version            : 2.99.917
 ++ Xorg-Xserver version                : 1.18.99.1
 ++ DRM version                         : 2.4.68
 ++ VAAPI version                       : Intel i965 driver for Intel(R) Kabylake - 1.7.1.pre1 (1.7.0-23-g0be0b21)
 ++ Cairo version                       : 1.15.2
 ++ Intel GPU Tools version             : Tag [intel-gpu-tools-1.14-319-gb88bce4] / Commit [b88bce4]
 ++ Kernel driver in use                : i915


 |=== Hardware information ===|

 ++ Platform                            : KBL (RVP7)
 ++ Motherboard model                   : Kabylake Client platform
 ++ Motherboard type                    : Skylake U DDR3L RVP7 Laptop
 ++ Motherboard manufacturer            : Intel Corporation
 ++ CPU information                     : Genuine Intel(R) CPU 0000 @ 2.60GHz
 ++ GPU Card                            : Intel Corporation Device 5916 (prog-if 00 [VGA controller])
Comment 6 Luis Botello 2016-05-24 00:08:22 UTC
I also have tested over APL and i got the following results:

 |=== Software information ===|

 ++ Kernel version                      : 4.6.0-drm-intel-nightly-ww21-commit-2ec8239+
 ++ Linux distribution                  : Ubuntu 16.04 LTS
 ++ Architecture                        : 64-bit
 ++ xf86-video-intel version            : 2.99.917
 ++ Xorg-Xserver version                : 1.18.99.1
 ++ DRM version                         : 2.4.68
 ++ VAAPI version                       : Intel i965 driver for Intel(R) Broxton - 1.7.1.pre1 (1.7.0-23-g0be0b21)
 ++ Cairo version                       : 1.15.2
 ++ Kernel driver in use                : i915


 |=== Hardware information ===|

 ++ Platform                            : BXT-P
 ++ Motherboard model                   : Broxton P
 ++ Motherboard type                    : NOTEBOOK Hand Held
 ++ Motherboard manufacturer            : Intel Corp.
 ++ CPU family                          : Other
 ++ CPU information                     : 06/5c
 ++ GPU Card                            : Intel Corporation Device 5a84 (rev 0a) (prog-if 00 [VGA controller])

=========================================================================


bad commit :

commit b88bce40a25d2393a51298f0d699e66491975cc9
Author: Mika Kuoppala <mika.kuoppala@intel.com>
Date:   Fri May 13 16:53:57 2016 +0300

    tests/gem_evict_everything: use uint64_t in subtest params

    Use large enough datatype so that we get the accurate
    mem requirements and thus skips on 48bit ppgtt.

    References: https://bugs.freedesktop.org/show_bug.cgi?id=94146
    Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
    Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>

 - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - 

good commit : 

commit 5cc3175ca5a0374c17bd201ba5a35ef4ff076003
Author: Feceoru, Gabriel <gabriel.feceoru@intel.com>
Date:   Fri May 13 14:45:09 2016 +0300

    tests/kms_flip: Adjust tolerance when counting frames

    basic-flip-vs-wf_vblank subtest sometimes fails asserting counted frames to
    be aproximately equal with the estimated number.

    This is a false negative, one of the reasons being the precision lost when
    truncating a fractional number.

    Fixed this by using floating point arithmetic.

    Cc: Jani Nikula <jani.nikula@intel.com>
    Cc: Daniel Vetter <daniel.vetter@intel.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95380 [mvlad]
    Signed-off-by: Gabriel Feceoru <gabriel.feceoru@intel.com>
    Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>

 - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - 

good commit:

commit 9579e5447aa304d0b8d36688b8d0da0c97ca284a
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Mon May 23 21:56:01 2016 +0100

    test: Add legacy cursor stress test

    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Comment 7 cprigent 2016-05-24 07:23:00 UTC
So resolved as fixed
Comment 8 cprigent 2016-05-24 07:23:10 UTC
Closed


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.