Bug 957 - improve syntax of /etc/init.d/xprint
Summary: improve syntax of /etc/init.d/xprint
Status: RESOLVED WONTFIX
Alias: None
Product: xprint
Classification: Unclassified
Component: Server: Config: startup scripts (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Roland Mainz
QA Contact:
URL: http://bugs.debian.org/cgi-bin/bugrep...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-31 15:52 UTC by Drew Parsons
Modified: 2011-09-13 12:36 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Drew Parsons 2004-07-31 15:52:08 UTC
Debian bug reporters indicates the syntax of /etc/init.d/xprint could be
improved a little.

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=258419 reports that a simple
patch is needed for tr to run properly:

--- xprint.orig Fri Jun 18 11:19:20 2004
+++ xprint      Thu Jul  8 17:47:48 2004
@@ -242,7 +242,7 @@
               tok="${val#*=}"
           done
       done
-    ) | tr "," "[\n]" | fontpath2fontlist
+    ) | tr "," "\n" | fontpath2fontlist
 }
 
 get_fontlist_from_all_xfs_configs()


Roland, can you confirm that this patch without the '[' is in fact correct?  If
so, I'll patch it straight into the Debian version until v10 is ready.


Also, I think you've already seen the comments on POSIX compliance at
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=256241.  This seems like an
appriopriate place to put it into your bugzilla.  I guess the -a issue is as
simple as replacing the -a with && (closing square brackets with ]
appropriately).  I might experiment with this myself and report back later.

As for whether ksh or bash is used by default in /etc/init.d/xprint, I can apply
a purely Debian patch at my end to swap them around, so it's not strictly
necessary for you to allow for it at your end, although you could use "if [
"${XPCUSTOMGLUE}" = "DebianGlue" ]" if you really wanted to.  ksh93's licence is
not, I believe, Free enough for it to go into Debian.

Drew
Comment 1 Corbin Simpson 2011-09-13 12:36:58 UTC
Closing WONTFIX because nobody cares about Xprint. Reopen if you plan to address this bug.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.