Bug 9579 - Channel type iface is not unref when the channel is destroyed
Summary: Channel type iface is not unref when the channel is destroyed
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: libtelepathy (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-09 04:16 UTC by Xavier Claessens
Modified: 2007-04-23 12:03 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
proposed patch (715 bytes, patch)
2007-01-09 04:16 UTC, Xavier Claessens
Details | Splinter Review
Additional patch (535 bytes, patch)
2007-01-14 11:09 UTC, Sjoerd Simons
Details | Splinter Review

Description Xavier Claessens 2007-01-09 04:16:17 UTC
... and this cause gossip to crash ...
Comment 1 Xavier Claessens 2007-01-09 04:16:46 UTC
Created attachment 8341 [details] [review]
proposed patch
Comment 2 Sjoerd Simons 2007-01-14 11:09:41 UTC
Created attachment 8395 [details] [review]
Additional patch

Next to this patch, this one is probably wanted.. To ensure the interface
proxy's are not replaced if the CM signals connected multiple times (Salut has
a bug which causes this currently). Which can cause say gossip to crash as it
assumes that all interfaces proxies are valid for the livetime of the
Connection.

A better fix might be to clear the interfaces if the connection goes to not
connected, refill it when the connection is connected again.. And tell 
application writers that interfaces are only valid as long as the connection 
is actually connected.

But that might be just overdoing it because a Connection only goes to connected
at most one time with the contemporary CM's (As the connection object goes away
if the connection is disconnected)
Comment 3 Simon McVittie 2007-01-17 02:09:57 UTC
> a Connection only goes to connected at most one time with the contemporary CM's

I believe that's mandated by the specification - you'd get a NewConnection
signal if a Connection somehow came back.
Comment 4 Simon McVittie 2007-04-23 12:03:48 UTC
Fixed in 0.0.42.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.