Bug 96244 - libwebrtc_audio_processing undefined symbols
Summary: libwebrtc_audio_processing undefined symbols
Status: RESOLVED FIXED
Alias: None
Product: PulseAudio
Classification: Unclassified
Component: modules (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: pulseaudio-bugs
QA Contact: pulseaudio-bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-27 13:46 UTC by Rex Dieter
Modified: 2016-06-01 04:41 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
enforce linking with --no-undefined, add explicit -lpthread linkage (1.14 KB, patch)
2016-05-27 13:46 UTC, Rex Dieter
Details | Splinter Review

Description Rex Dieter 2016-05-27 13:46:18 UTC
Created attachment 124127 [details] [review]
enforce linking with --no-undefined, add explicit -lpthread linkage

In investigating x86/sse2 issues in recent webrtc-audio-processing-0.2 release, I found that it was possible for libwebrtc_audio_processing to contain undefined symbols.

Attached is a patch that addresses this:
* adds -Wl,--no-undefined to libwebrtc_audio_processing_la_LDFLAGS 
* adds explicit -lpthread linkage (else, there are undefined references to pthread-related symbols)
Comment 1 Arun Raghavan 2016-06-01 04:41:49 UTC
Thanks! I made some minor fixes and pushed this. It's easier for me if you can provide git format-patch patches (but I can just do that for you if it's too painful).


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.