Bug 96273 - Remove SIGIO support for input [v5] in xserver causes xf86-input-evdev build fail
Summary: Remove SIGIO support for input [v5] in xserver causes xf86-input-evdev build ...
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/Input/Core (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-30 00:41 UTC by charlie
Modified: 2016-05-30 18:51 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
xf86-input-evdev builderror.log (2.04 KB, text/x-log)
2016-05-30 00:41 UTC, charlie
no flags Details
xf86-input-evdev install attempt log (990 bytes, text/x-log)
2016-05-30 00:44 UTC, charlie
no flags Details

Description charlie 2016-05-30 00:41:50 UTC
Created attachment 124167 [details]
xf86-input-evdev builderror.log

xserver git source commit "Remove SIGIO support for input [v5]" causes xf86-input-evdev build fail.

https://cgit.freedesktop.org/xorg/xserver/commit/?id=6a5a4e60373c1386b311b2a8bb666c32d68a9d99

P.S. I was not sure if I should have submitted the bug to the "Input/evdev" category.
Comment 1 charlie 2016-05-30 00:44:00 UTC
Created attachment 124168 [details]
xf86-input-evdev install attempt log
Comment 2 Keith Packard 2016-05-30 18:51:40 UTC
Fixed by 28b2c880a9dbfd91e82397a0f22482d258a8b670:

    xfree86: Provide xf86BlockSIGIO and xf86ReleaseSIGIO as wrappers for input mutex
    
    Threaded input doesn't use SIGIO anymore, but existing drivers using
    xf86BlockSIGIO and xf86ReleaseSIGIO probably want to lock the input
    mutex during those operations. Provide inline functions to do this
    which are marked as 'deprecated' so that drivers will get warnings
    until they are changed.
    
    Signed-off-by: Keith Packard <keithp@keithp.com>
    Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.