Bug 96300 - piglit.spec.arb_direct_state_access.gettransformfeedback regression
Summary: piglit.spec.arb_direct_state_access.gettransformfeedback regression
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Dave Airlie
QA Contact: Intel 3D Bugs Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 96253
  Show dependency treegraph
 
Reported: 2016-05-31 23:59 UTC by Mark Janes
Modified: 2016-06-01 02:07 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Mark Janes 2016-05-31 23:59:08 UTC
bac39dd regressed this test:
mesa/xfb: report calculated size for XFB buffer objects.

This fixes:
GL45-CTS.direct_state_access.xfb_buffers

This test looks correct to me, we should work out the
size value and report it rather than using only the size
from the Range interface.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>


piglit/bin/arb_direct_state_access-gettransformfeedback -auto -fbo
piglit: debug: Requested an OpenGL 3.1 Forward-Compatible Core Context, and received a matching 4.3 context

Unexpected GL error: GL_INVALID_ENUM 0x500
(Error at ../tests/spec/arb_direct_state_access/gettransformfeedback.c:197)
Comment 1 Kenneth Graunke 2016-06-01 02:07:03 UTC
Fixed by:

commit 8a3ca58eecad48f7c479ef2df3929d8b7fd4bbe3
Author: Dave Airlie <airlied@redhat.com>
Date:   Tue May 31 09:54:08 2016 +1000

    dsa/xfb: make the buffer large enough.
    
    This bug in the test was triggered by a fix to mesa, the test creates
    a backing buffer smaller than the xfb range it requests then is surprised
    when it gets returned a truncated value for the size.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96300
    Signed-off-by: Dave Airlie <airlied@redhat.com>
    Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.