Bug 96327 - Assertion failure in radeon_drm_cs.c (Shadow of Mordor)
Summary: Assertion failure in radeon_drm_cs.c (Shadow of Mordor)
Status: RESOLVED WORKSFORME
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/Gallium/radeonsi (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: medium minor
Assignee: Jan Ziak (http://atom-symbol.net)
QA Contact: Default DRI bug account
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-02 16:24 UTC by Jan Ziak (http://atom-symbol.net)
Modified: 2016-10-17 22:01 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Jan Ziak (http://atom-symbol.net) 2016-06-02 16:24:02 UTC
Mesa 12.1.0-devel (git-6c9a352)

src/gallium/winsys/radeon/drm/radeon_drm_cs.c:388: radeon_drm_cs_check_space: Assertion `rcs->current.cdw <= rcs->current.max_dw' failed.

I can try to generate a backtrace if needed.
Comment 1 Michel Dänzer 2016-06-03 00:25:42 UTC
Is this a regression? If yes, can you bisect?
Comment 2 Jan Ziak (http://atom-symbol.net) 2016-06-05 22:36:20 UTC
This is a data race issue caused by incorrect locking of gl_context by the game. The game is indirectly using the same gl_context from two OS threads.
Comment 3 Nicolai Hähnle 2016-06-07 23:22:32 UTC
I take it this means this can be closed as NOTOURBUG?
Comment 4 Jan Ziak (http://atom-symbol.net) 2016-06-09 09:59:00 UTC
(In reply to Nicolai Hähnle from comment #3)
> I take it this means this can be closed as NOTOURBUG?

If it was my decision to make, I would still fix it in Mesa because it slightly broadens the range of stable applications and slightly increases end-user satisfaction.

Programming bugs cannot be prevented in an absolute sense.

If possible Mesa should print a warning with backtraces (libunwind?) which would help application developers to locate the problem.

I suggest to leave this bug open.
Comment 5 Marek Olšák 2016-10-17 21:38:31 UTC
A Feral representative told me that Shadow Of Mordor works.
Comment 6 Jan Ziak (http://atom-symbol.net) 2016-10-17 22:01:58 UTC
(In reply to Marek Olšák from comment #5)
> A Feral representative told me that Shadow Of Mordor works.

Just a note:

I protect a number of OpenGL API functions by a mutex added via a private patch to my local Mesa installation, so Shadow of Mordor works OK on my machine. Prior to that, I was experiencing failures in this game, mostly in the game menu.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.