Bug 96465 - Support for 'DMS ChangeDeviceDownLoadMode' command
Summary: Support for 'DMS ChangeDeviceDownLoadMode' command
Status: RESOLVED FIXED
Alias: None
Product: libqmi
Classification: Unclassified
Component: libqmi (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: Dan Williams
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-09 20:31 UTC by Aliaksandr Barouski
Modified: 2016-10-24 10:36 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Patch with call implementation (1.73 KB, patch)
2016-06-09 20:31 UTC, Aliaksandr Barouski
Details | Splinter Review
Updated patch (with call from qmi-cli) (6.44 KB, patch)
2016-07-07 22:52 UTC, Aliaksandr Barouski
Details | Splinter Review

Description Aliaksandr Barouski 2016-06-09 20:31:52 UTC
Created attachment 124427 [details] [review]
Patch with call implementation

Support for changing device download mode via the library.

Added support for 'DMS ChangeDeviceDownLoadMode'. This call is needed for HP lt4120 LTE modem (may be for other Qualcomm Snapdragon X5 modems) for update firmware in modem. This call reboots device to Fastboot mode
Comment 1 Aleksander Morgado 2016-07-07 19:19:48 UTC
Comment on attachment 124427 [details] [review]
Patch with call implementation

Review of attachment 124427 [details] [review]:
-----------------------------------------------------------------

::: data/qmi-service-dms.json
@@ +1196,5 @@
> +     "input"   : [  { "name"         : "Mode",
> +                      "id"           : "0x01",
> +                      "mandatory"    : "yes",
> +                      "type"         : "TLV",
> +                      "format"       : "guint8"

This Mode parameter looks like an enumeration; do you have the list of possible values that may be sent?
Comment 2 Aliaksandr Barouski 2016-07-07 22:52:35 UTC
Created attachment 124951 [details] [review]
Updated patch (with call from qmi-cli)

Updated patch (added call from qmi-cli)

It should be Enum, but I have no idea which values is used. 
Value 5 restarts hp4120 modem (and may be other x5 modems) to Fastboot mode.

Example of usage: https://github.com/borovsky/x5-snapdragon-linux/blob/master/copy-firmware.sh
Comment 3 Aleksander Morgado 2016-10-24 10:36:00 UTC
I've pushed a slightly modified version of the last patch to git master. Basically, to avoid requiring a qmicli_read_uint8_from_string() method, which wasn't included in the patch (and build failed) and also to split the Input bundle creation in its own method.

Thanks!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.