Bug 96610 - Enable treating warnings as errors
Summary: Enable treating warnings as errors
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/openchrome (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Openchrome development list
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-21 08:37 UTC by Bartosz Kosiorek
Modified: 2016-08-21 00:12 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Bartosz Kosiorek 2016-06-21 08:37:35 UTC
Currently in Openchrome there are a lot of warnings.
It is causing that it is hard to notice, that some new warning appear.

It is error prone, as developers could miss some new important warning and introduce regression, which could be easily avoided by noticing warnings.

To improve quality I would propose to enable "Make all warnings into errors." option:
https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html
Comment 1 Kevin Brace 2016-07-28 23:32:35 UTC
(In reply to Bartosz Kosiorek from comment #0)

Hi Bartosz,

> Currently in Openchrome there are a lot of warnings.
> It is causing that it is hard to notice, that some new warning appear.
> 
> It is error prone, as developers could miss some new important warning and
> introduce regression, which could be easily avoided by noticing warnings.
> 
> To improve quality I would propose to enable "Make all warnings into
> errors." option:
> https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html

I am pretty sure I am the one who introduced many of the warnings, and I am willing to deal with it to some extent for OpenChrome Version 0.6.
That being said, can you tell me how to accomplish this exactly.
Comment 2 Kevin Brace 2016-08-12 07:13:38 UTC
Hi Bartosz,

I overcame the problem by adding CFLAGS option to when autogen.sh is executed from the terminal.

./autogen.sh --prefix=/usr --enable-debug --enable-xv-debug --enable-viaregtool CFLAGS="-Wall"

I can now see all the warnings.
I now consider this problem resolved.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.