Bug 96846 - Some incorrect internal header files path found
Summary: Some incorrect internal header files path found
Status: RESOLVED INVALID
Alias: None
Product: poppler
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other Linux (All)
: medium normal
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-07 12:53 UTC by David GEIGER
Modified: 2016-07-10 22:38 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description David GEIGER 2016-07-07 12:53:44 UTC
Hi,

I get some issues when I try to compile a project needing headers files from poppler:
 
  * On example:

In file included from /usr/include/poppler/splash/SplashTypes.h:28:0,
                 from /usr/include/poppler/splash/SplashBitmap.h:37,
                 from src/pdf/XPDFRenderer.h:34,
                 from src/pdf/PDFRenderer.cpp:35:
/usr/include/poppler/goo/gtypes.h:28:28: fatal error: poppler-config.h: No such file or directory
compilation terminated.

This come from the header file who not pointed the right path.

If you see in /usr/include/poppler/goo/gtypes.h there is a 
#include "poppler-config.h" but this path does not exist, it should be:
#include "poppler/poppler-config.h"

  * Another example:

In file included from /usr/include/poppler/splash/SplashBitmap.h:37:0,
                 from src/pdf/XPDFRenderer.h:34,
                 from src/pdf/PDFRenderer.cpp:35:
/usr/include/poppler/splash/SplashTypes.h:28:24: fatal error: goo/gtypes.h: No such file or directory
compilation terminated.

Same here, if you see in /usr/include/poppler/splash/SplashTypes.h there is a 
#include "goo/gtypes.h" but this path does not exist, it should be:
#include "poppler/goo/gtypes.h"

This is two examples but I think there are a lot of others who still need to be fixed so.

Regards,
David
Comment 1 Jason Crain 2016-07-07 14:44:07 UTC
Why not include the path in your CPPFLAGS, instead?
Comment 2 David GEIGER 2016-07-07 14:47:30 UTC
Ah yes why not! this is also a good solution.

So sorry for the noise :)


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.