Bug 96917 - unit tests fail if network manager support is enabled
Summary: unit tests fail if network manager support is enabled
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: mission-control (show other bugs)
Version: unspecified
Hardware: Other All
: medium blocker
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard: 5.16.4
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-07-13 14:56 UTC by George Kiagiadakis
Modified: 2016-09-01 18:54 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
tests: make tests work again when NM support is enabled (2.62 KB, patch)
2016-08-15 08:40 UTC, George Kiagiadakis 		Details | Splinter Review
View All

Description George Kiagiadakis 2016-07-13 14:56:26 UTC 
In the 5.16 branch, unit tests fail if nm support is enabled. Adding --with-connectivity=no in configure fixes it.
Comment 1 George Kiagiadakis 2016-08-15 08:40:18 UTC 
Created attachment 125788 [details] [review]
tests: make tests work again when NM support is enabled

Found the issue, it was because the Settings object of NM was not implemented in our fake NM implementation.
Comment 2 George Kiagiadakis 2016-09-01 18:54:43 UTC 
commit 78d8c53b930323455bb7c4031903f46717b8a174
Author: George Kiagiadakis <gkiagia@tolabaki.gr>
Date:   Mon Aug 15 11:37:24 2016 +0300

    tests: make tests work again when NM support is enabled
    
    Apparently the nm library also tries to access the /.../Settings
    object of NM, which was not available in our fake NM implementation.
    This commit implements the basic properties of the Settings object,
    which allows the tests to continue past this point.
    
    https://bugs.freedesktop.org/show_bug.cgi?id=96917

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.