Bug 97016 - autoconf: Don't use deprecated GNOME_ macros
Summary: autoconf: Don't use deprecated GNOME_ macros
Status: RESOLVED MOVED
Alias: None
Product: cups-pk-helper
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Marek Kasik
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-21 10:20 UTC by Guido Guenther
Modified: 2018-10-12 21:17 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Drop deprecated (and unused) GNOME_MAINTAINER_MODE_DEFINES (734 bytes, patch)
2016-07-21 10:20 UTC, Guido Guenther 		Details | Splinter Review
Use AX_COMPILER_FLAGS instead of GNOME_COMPILE_WARNINGS (1.44 KB, patch)
2016-07-21 10:21 UTC, Guido Guenther 		Details | Splinter Review
Don't compare signed and unsigned int (2.83 KB, patch)
2016-07-21 10:22 UTC, Guido Guenther 		Details | Splinter Review
Add default statements to silence compiler warnings (2.30 KB, patch)
2016-07-21 10:22 UTC, Guido Guenther 		Details | Splinter Review
Don't use g_type_init on recent glib (1.88 KB, patch)
2016-07-21 10:23 UTC, Guido Guenther 		Details | Splinter Review
View All

Description Guido Guenther 2016-07-21 10:20:50 UTC 
Created attachment 125206 [details] [review]
Drop deprecated (and unused) GNOME_MAINTAINER_MODE_DEFINES

The attached patches get rid of GNOME_COMPILE_WARNINGS [1] and GNOME_MAINTAINER_MODE_DEFINES . Follow up patches fix the warnings spotted by the usage of AX_COMPILER_FLAGS.

[1]: https://git.gnome.org/browse/gnome-common/commit/?id=b57bae0be
Comment 1 Guido Guenther 2016-07-21 10:21:22 UTC 
Created attachment 125209 [details] [review]
Use AX_COMPILER_FLAGS instead of GNOME_COMPILE_WARNINGS
Comment 2 Guido Guenther 2016-07-21 10:22:07 UTC 
Created attachment 125211 [details] [review]
Don't compare signed and unsigned int
Comment 3 Guido Guenther 2016-07-21 10:22:58 UTC 
Created attachment 125214 [details] [review]
Add default statements to silence compiler warnings
Comment 4 Guido Guenther 2016-07-21 10:23:36 UTC 
Created attachment 125216 [details] [review]
Don't use g_type_init on recent glib
Comment 5 Guido Guenther 2016-07-21 10:27:27 UTC 
In case it's simpler i've pushed the whole series here:

    https://github.com/agx/cups-pk-helper/tree/deprecate-gnome-common
Comment 6 GitLab Migration User 2018-10-12 21:17:19 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/cups-pk-helper/cups-pk-helper/issues/4.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.