Bug 97078 - [CTS] shaders.shader_integer_mix.define regression
Summary: [CTS] shaders.shader_integer_mix.define regression
Status: RESOLVED NOTOURBUG
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Ian Romanick
QA Contact: Intel 3D Bugs Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-25 15:25 UTC by Mark Janes
Modified: 2016-08-19 23:42 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Mark Janes 2016-07-25 15:25:31 UTC
This test began failing at the series ending in e483cb9

Author:     Ilia Mirkin <imirkin@alum.mit.edu>
glsl: reuse main extension table to appropriately restrict extensions

cts/glcts --deqp-case=ES31-CTS.shader_integer_mix.define
dEQP Core GL-CTS-2.0 (0x0052484b) starting..
  target implementation = 'intel-gbm'

Test case 'ES31-CTS.shader_integer_mix.define'..
  Fail (Fail)

DONE!

Test run totals:
  Passed:        0/1 (0.00%)
  Failed:        1/1 (100.00%)
  Not supported: 0/1 (0.00%)
  Warnings:      0/1 (0.00%)
Comment 1 Ilia Mirkin 2016-07-25 15:49:58 UTC
I'm moderately sure that the CTS tests are wrong (and I mention that in the commit message). I don't have access to fix it [or even see the CTS tests], so some KHR member will have to resolve it. Reassigning back to Ian (not suggesting he have to fix it, but he's the default for the category, and there's not a ton I can do about it).

The tests do #version 100, they should do #version 300 es (or #version 310 es).

If the decision is that the CTS tests are, in fact, correct, then I'd be happy to do the work of piping through that information in the new extension-exposing infrastructure.
Comment 2 Jordan Justen 2016-08-18 00:10:44 UTC
I pushed a master-gbm-es31-gen7 branch to the internal cts repo.

It has a patch, which fixes this.

commit 8011324d2196ed28cfc500a3652bcae5d95c50e8
Author: Jordan Justen <jordan.l.justen@intel.com>
Date:   Wed Aug 17 15:50:02 2016 -0700

    GL_EXT_shader_integer_mix: use OpenGLES 3.0 version in shader source

Should we pull that patch into the master-gbm branch?
Comment 3 Mark Janes 2016-08-19 23:42:51 UTC
I pulled this into the CI branch that we test against and confirmed that it fixes the test.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.