Bug 97087 - Pavucontrol does not define GTK+3.20 selector
Summary: Pavucontrol does not define GTK+3.20 selector
Status: RESOLVED MOVED
Alias: None
Product: PulseAudio
Classification: Unclassified
Component: pavucontrol (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: pulseaudio-bugs
QA Contact: pulseaudio-bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-26 10:53 UTC by Steffen
Modified: 2018-07-30 09:28 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Steffen 2016-07-26 10:53:41 UTC
Because Pavucontrol does not define a GTK+3.20 selector, it is impossible to target GTK styles direct at Pavucontrol. This has let to problems in MATE Desktop, where the default style had to be changed to make pavucontrol look nice. However that in turn broke the style of other applications.

Related bug report in MATE Desktop.
https://github.com/mate-desktop/mate-themes/issues/130
Comment 1 Wolfgang Ulbrich 2016-07-26 11:23:05 UTC
Can you please add missing style classes to pavu-control for gtk+-3.20?
1. one at top level, eg. pavu-control, in result i can use
window.background.pavu-control > box.vertical > notebook {
}
for styling the notebook and others.
2. Adding the style class .frame to the notebook, because most preferences windows use notebook.frame {}.
So pavu-control will use the same styling from themes without writing extra code for it.

Curently i need to use a ugly hack for making pavu-control nice.

window.background > box.vertical > notebook {
}

The problem is that GtkNotebook is everywhere in application code, so with such a setting i match also other application, eg. virt-manager, mate-terminal, gnome-terminal and others, and i have to override the settings for pavu-control again.

So adding those 2 style classes will make my live easier, and users will have a nice linux experience with gtk+-3.20.

Note, also other gnome applications like nautilus have added such a top selector for gtk+-3.20

Thank you
Comment 2 Arun Raghavan 2016-07-28 04:51:23 UTC
Could you either provide a patch, or provide an example of what needs to be done?
Comment 3 Steffen 2016-07-30 10:40:12 UTC
I think it should be done the same way as shown here:
https://github.com/mate-desktop/caja/blob/master/src/caja-desktop-window.c#L57

#if GTK_CHECK_VERSION(3, 0, 0)
    GtkStyleContext *context;

    context = gtk_widget_get_style_context (GTK_WIDGET (window));
    gtk_style_context_add_class (context, "caja-desktop-window");
#endif
Comment 4 GitLab Migration User 2018-07-30 09:28:07 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/pulseaudio/pavucontrol/issues/12.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.