Bug 97237 - Make it build with MSVC
Summary: Make it build with MSVC
Status: RESOLVED MOVED
Alias: None
Product: fontconfig
Classification: Unclassified
Component: library (show other bugs)
Version: unspecified
Hardware: Other Windows (All)
: medium normal
Assignee: fontconfig-bugs
QA Contact: Behdad Esfahbod
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-08 07:25 UTC by Ignacio Casal Quinteiro
Modified: 2018-08-20 21:50 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ignacio Casal Quinteiro 2016-08-08 07:25:14 UTC
On our downstream gtk-win32 project we are maintaining a patch for quite a while already to make it build with MSVC. It would be great if somebody could take the interesting parts from it and push it upstream:

https://github.com/wingtk/gtk-win32/blob/master/fontconfig/fontconfig.patch
Comment 1 Akira TAGOH 2016-08-15 07:22:51 UTC
One concern before applying that patch, does it still work on MinGW? they also use WIN32 on ifdef lines.
Comment 2 LRN 2017-03-02 19:32:57 UTC
All i can say is that mingw-w64 fontconfig-2.12.1 builds with this patch and passes all tests in the testsuite (all 4 of them...).
Comment 3 LRN 2017-03-03 05:19:39 UTC
Though you should probably define FLEXIBLE_ARRAY_MEMBER to 1 (MSVC doesn't run the configure script, which detects this and defines this macro) instead of hardcoding 1 there.
Comment 4 GitLab Migration User 2018-08-20 21:50:59 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/fontconfig/fontconfig/issues/85.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.