Bug 975 - Xfixes code in Xcursor not compiled when imake is used
Summary: Xfixes code in Xcursor not compiled when imake is used
Status: RESOLVED WONTFIX
Alias: None
Product: xorg
Classification: Unclassified
Component: Lib/Xcursor (show other bugs)
Version: git
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Chris Lee
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-03 12:35 UTC by Fredrik Höglund
Modified: 2006-03-05 01:30 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Xfixes support for Xcursor when using imake (1.39 KB, patch)
2004-08-05 18:14 UTC, Chris Lee
no flags Details | Splinter Review

Description Fredrik Höglund 2004-08-03 12:35:06 UTC
Xcursor relies on a configure check to determine if the Xfixes library is 
available, but when imake is used to build Xcursor that check isn't run, which 
causes the calls to XFixesSetCursorName() to be #ifdefed out. 
 
Adding -DHAVE_XFIXES to CFLAGS and linking to libXfixes should fix the 
problem.
Comment 1 Chris Lee 2004-08-05 18:14:28 UTC
Created attachment 580 [details] [review]
Xfixes support for Xcursor when using imake

This is a first hack at a patch to make this work. May not be the Right Way;
Should I just change SharedXcursorReqs in the config/cf tree?
Comment 2 Mike A. Harris 2005-04-28 18:15:42 UTC
Our rpms build xorg with Xfixes and Xcursor and do not experience this
problem.  Is it possible this was a bug that has been fixed for a while
now but the bug left open?
Comment 3 Alan Coopersmith 2005-10-09 14:52:51 UTC
Xcursor built in monolith CVS head still was not calling XFixesSetCursorName,
but adding this patch made it do so, so I went ahead and committed a subset of
it:

@@ -40,11 +41,16 @@
 XRENDER_CFLAGS=-I$(INCROOT)
 #endif
 
+#if BuildXfixesLibrary
+XFIXES_DEFINES = -DHAVE_XFIXES
+REQUIREDLIBS += $(XFIXESLIB)
+#endif
+
 RPATH_CFLAG = HardCodeLibdirFlag
 
 ICONDIR=$(LIBDIR)/icons
 
-DEFINES=-DICONDIR=\"$(ICONDIR)\"
+DEFINES=-DICONDIR=\"$(ICONDIR)\" $(XFIXES_DEFINES)
 
 SRCS = cursor.c display.c file.c library.c xlib.c

I'm not sure if any of the rest is necessary or not - this was enough to have
nm show that libXcursor now included calls to XFixesSetCursorName and for ldd
to show that libXcursor was linked against libXfixes.   I'll leave this open
in case anyone else wants to work on that (though I suspect it will be closed
as "WONTFIX - monolith is dead" in a year or so).

Comment 4 Daniel Stone 2006-03-05 20:30:39 UTC
monolith is dead


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.