Author: Antia Puentes <firstname.lastname@example.org>
i965: Fix calculation of the image height at start level
dEQP Core GL-CTS-2.0 (0x0052484b) starting..
target implementation = 'intel-gbm'
Test case 'ES2-CTS.gtf.GL2ExtensionTests.egl_image_external.TestSimpleUnassociated'..
glcts: /home/jenkins/workspace/Leeroy_2/repos/mesa/src/mesa/drivers/dri/i965/intel_tex_image.c:70: intel_miptree_create_for_teximage: Assertion `!"Unexpected target"' failed.
Looks like GL_TEXTURE_EXTERNAL_OES was forgotten. Should be added to the no-mipmaps case, I believe.
(In reply to Mark Janes from comment #0)
> intel_tex_image.c:70: intel_miptree_create_for_teximage: Assertion
> `!"Unexpected target"' failed.
FWIW, this regression doesn't happen on all hw. It happens on Haswell for example. But on Skylake, with or without that patch, it asserts on a different place:
glcts: intel_mipmap_tree.c:2191: intel_miptree_make_shareable: Assertion `mt->msaa_layout == INTEL_MSAA_LAYOUT_NONE' failed.
Pending to test on Broadwell.
In any case, we will take a look to this, in order to solve the issue on the hw that caused an regression. Thanks to Ilia for his hint.
(In reply to Alejandro Piñeiro (freenode IRC: apinheiro) from comment #2)
> Pending to test on Broadwell.
Confirmed that the patch introduces a regression on Broadwell too.
Just sent a series that fixes the regression:
Note that the test still crashes on Skylake, but that is unrelated with the problem detected on this bug (it was crashing before the commit at comment 0).
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct.