Bug 97898 - [PATCH] Ensure config.h does not undefine sqrtf
Summary: [PATCH] Ensure config.h does not undefine sqrtf
Status: RESOLVED MOVED
Alias: None
Product: pixman
Classification: Unclassified
Component: pixman (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Oded Gabbay
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-22 14:32 UTC by Peter TB Brett
Modified: 2018-06-05 15:26 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Patch to configure.ac resolving the bug. (1.42 KB, patch)
2016-09-22 14:32 UTC, Peter TB Brett
Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Peter TB Brett 2016-09-22 14:32:38 UTC
Created attachment 126738 [details] [review]
Patch to configure.ac resolving the bug.

On Windows, sqrtf is a macro.  Previously, configure was detecting `sqrtf`'s availability, but then undefining it in config.h, resulting in link failures.
    
This patch modifies configure to use HAVE_SQRTF as a feature macro for the sqrtf() function, and adds an additional stanza to config.h which defines a suitable alternative when HAVE_SQRTF is not defined.
Comment 1 Siarhei Siamashka 2016-09-26 03:34:56 UTC
Thanks, for reporting this. Could you please provide a bit more details? Maybe with some error logs. I guess, this issue is not exactly Windows, but more like compiler dependent.

And if you could re-send the patch to the pixman mailing list, that would be the best.
Comment 2 GitLab Migration User 2018-06-05 15:26:34 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/pixman/pixman/issues/2.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.