Bug 98022 - p11-kit-proxy.so is not created on Mac OS X
Summary: p11-kit-proxy.so is not created on Mac OS X
Status: RESOLVED FIXED
Alias: None
Product: p11-glue
Classification: Unclassified
Component: p11-kit (show other bugs)
Version: unspecified
Hardware: All Mac OS X (All)
: medium normal
Assignee: Stef Walter
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-03 06:04 UTC by Leonardo Brondani Schenkel
Modified: 2016-10-03 16:50 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Leonardo Brondani Schenkel 2016-10-03 06:04:56 UTC
In the Makefile there's the following snippet:
$(LN_S) -f `readlink $(DESTDIR)$(libdir)/libp11-kit.so` $(DESTDIR)$(libdir)/p11-kit-proxy.so

However, on Mac OS X the library is named libp11-kit.dylib so in the above command the source of the link resolves to nothing, the destination becomes the source and the link to a non-existent file is created in the working directory.

The following patch fixes the issue:

--- BEGIN PATCH ---
diff --git a/p11-kit/Makefile.am b/p11-kit/Makefile.am
--- a/p11-kit/Makefile.am
+++ b/p11-kit/Makefile.am
@@ -87,7 +87,7 @@
 
 # Proxy module is actually same as library, so install a link
 install-exec-hook:
-	$(LN_S) -f `readlink $(DESTDIR)$(libdir)/libp11-kit.so` $(DESTDIR)$(libdir)/p11-kit-proxy.so
+	$(LN_S) -f `readlink $(DESTDIR)$(libdir)/libp11-kit.{so,dylib}` $(DESTDIR)$(libdir)/p11-kit-proxy.so
 	$(MKDIR_P) $(DESTDIR)$(p11_package_config_modules)
 
 endif
--- END PATCH ---

There is probably a more elegant way to do the above, but unfortunately I'm not an expert on autotools.
Comment 1 Stef Walter 2016-10-03 08:49:47 UTC
Thanks! Merged into git master.
Comment 2 Stef Walter 2016-10-03 08:50:32 UTC
Thanks. Merged into git master.
Comment 3 David Woodhouse 2016-10-03 16:50:17 UTC
AC_SUBST([SHARED_EXT], $(eval echo "${shrext_cmds}"))


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.