Bug 98133 - GetSynciv should raise an error if bufSize < 0
Summary: GetSynciv should raise an error if bufSize < 0
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Mesa core (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Tapani Pälli
QA Contact: mesa-dev
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: i965-deqp
  Show dependency treegraph
 
Reported: 2016-10-07 00:34 UTC by Kenneth Graunke
Modified: 2016-10-10 05:09 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Graunke 2016-10-07 00:34:37 UTC
dEQP-GLES31.functional.debug.negative_coverage.callbacks.state.get_synciv
dEQP-GLES31.functional.debug.negative_coverage.get_error.state.get_synciv
dEQP-GLES31.functional.debug.negative_coverage.log.state.get_synciv

expect GetSynciv to raise an error if bufSize < 0.  We should check if this is actually an error condition in ES.
Comment 1 Tapani Pälli 2016-10-10 05:09:07 UTC
commit 2d7e0f35c54f49c3280eea308a652253cb3bde46
Author: Tapani Pälli <tapani.palli@intel.com>
Date:   Fri Oct 7 08:41:15 2016 +0300

    mesa: throw error if bufSize negative in GetSynciv on OpenGL ES
    
    Fixes following dEQP tests:
    
       dEQP-GLES31.functional.debug.negative_coverage.callbacks.state.get_synciv
       dEQP-GLES31.functional.debug.negative_coverage.get_error.state.get_synciv
       dEQP-GLES31.functional.debug.negative_coverage.log.state.get_synciv
    
    v2: drop _mesa_is_gles check (Kenneth)
    
    Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98133
    Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.