expects INVALID_OPERATION instead of INVALID_ENUM in some cases. Haven't looked into which is right.
I think I have a fix for this but will run CI first to see if something blows up.
Created attachment 127094 [details] [review]
This patch fixes the test. These tests fail in CI though:
will take some more look later.
(In reply to Tapani Pälli from comment #2)
> Created attachment 127094 [details] [review] [review]
> This patch fixes the test. These tests fail in CI though:
> will take some more look later.
OK those failures were bogus, I just run same patch with current master and no regressions were observed. Will cleanup the patch and send to the list.
Author: Tapani Pälli <email@example.com>
Date: Fri Oct 7 10:08:21 2016 +0300
mesa: fix error handling in DrawBuffers
Patch rearranges error checking so that enum checking provided via
destmask happens before other checks. It needs to be done in this
order because other error checks do not work properly if there were
invalid enums passed.
Patch also refines one existing check and it's documentation to match
GLES 3.0 spec (also in later specs). This was somewhat mysteriously
referring to desktop GL but had a check for gles3.
Fixes following dEQP tests:
no CI regressions observed.
Signed-off-by: Tapani Pälli <firstname.lastname@example.org>
Cc: "12.0 13.0" <email@example.com>
Reviewed-by: Emil Velikov <firstname.lastname@example.org>
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct.