Bug 98179 - Create a threaded mechanism for input [v7] patches breaks VirtualBox build
Summary: Create a threaded mechanism for input [v7] patches breaks VirtualBox build
Status: RESOLVED WONTFIX
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL: https://www.virtualbox.org/ticket/16052
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-10 05:20 UTC by Sérgio M. Basto
Modified: 2016-11-17 11:36 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Sérgio M. Basto 2016-10-10 05:20:36 UTC
https://cgit.freedesktop.org/xorg/xserver/commit/?id=30ac7567980a1eb79d084a63e0e74e1d9a3af673

this part of code  breaks build of VBox 

diff --git a/include/os.h b/include/os.h
index e9b3709..20224f1 100644
--- a/include/os.h
+++ b/include/os.h
@@ -706,4 +706,9 @@ xorg_backtrace(void);
 extern _X_EXPORT int
 os_move_fd(int fd);
 
+#include <signal.h>
+
+extern _X_EXPORT int
+xthread_sigmask(int how, const sigset_t *set, sigset_t *oldest);
+
 #endif                          /* OS_H */


Builds ends with:
In file included from /usr/include/xorg/misc.h:117:0,
                 from /usr/include/xorg/xf86str.h:37,
                 from /builddir/build/BUILD/VirtualBox-5.1.6/src/VBox/Additions/x11/vboxvideo/vboxvideo.h:107,
                 from /builddir/build/BUILD/VirtualBox-5.1.6/src/VBox/Additions/x11/vboxvideo/getmode.c:18:
/usr/include/xorg/os.h:708:32: error: unknown type name 'sigset_t'
 xthread_sigmask(int how, const sigset_t *set, sigset_t *oldest);
                                ^~~~~~~~
/usr/include/xorg/os.h:708:47: error: unknown type name 'sigset_t'
 xthread_sigmask(int how, const sigset_t *set, sigset_t *oldest);


where should be defined sigset_t ? 
removing these 3 lines Vbox builds without problems , what I am missing ? 

Thanks,
Comment 1 Thierry Vignaud 2016-11-17 11:36:02 UTC
I confirm this breaks building VirtualBox with xserver 1.19 but this is an issue that has to be fixed on VBox side:
https://www.virtualbox.org/ticket/16052


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.