Bug 98453 - libvdpau backend detection under Xwayland
Summary: libvdpau backend detection under Xwayland
Alias: None
Product: Mesa
Classification: Unclassified
Component: Other (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Aaron Plattner
QA Contact: mesa-dev
Depends on:
Reported: 2016-10-26 12:28 UTC by NicolasChauvet
Modified: 2017-03-05 13:14 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Return earlier if not vdpau_driver (1.70 KB, patch)
2016-10-26 12:28 UTC, NicolasChauvet
Details | Splinter Review

Description NicolasChauvet 2016-10-26 12:28:06 UTC
Created attachment 127552 [details] [review]
Return earlier if not vdpau_driver

This issue was previously reported as
[Wayland] libvdpau fails on (X)Wayland, trying to load libvdpau_nvidia.so on non-nvidia systems

Also note that there is no libvdpau Product in this bugzilla, I think it should be requested from the product owner to the freedesktop infra.

There is an issue with the way libvdpau tries (fails) to detect the appropriate backend if relevant:
1/ Under Xwayland. I have not tested myslef but according to the report, it should be possible to have vdpau acceleration under Xwayland (not native wayland even for gallium vdpau backends).
But the support is totally missing in libvdpau, so the default backend is tried (aka nvidia which for other reason doesn't work at all under current upstream XWayland).

2/ With recent Xorg-server (with DRI2 vdpau autodetection), it should be possible that there is no appropriate vdpau backend to choose and error with VDP_STATUS_NO_IMPLEMENTATION instead of trying nvidia and failing.

The problem with the attached patch is that it doesn't take the case where there is no DRI2 vdpau autodetection and defaulting to nvidia is better than nothing. (Hence the RFC tag).
The main benefit is that is will avoid a spurious message about nvidia, specially relevant when there is no nvidia hardware/driver at all.
Comment 1 Christian König 2016-10-26 12:44:41 UTC
Patch is Reviewed-by: Christian König <christian.koenig@amd.com>.

Please also send it to the VDPAU mailing list (vdpau@lists.freedesktop.org).
Comment 2 Christian Stadelmann 2017-03-05 11:56:53 UTC
Can we get this patch into the next mesa release, please?
Comment 3 Christian König 2017-03-05 13:13:55 UTC
libvdpau is not part of mesa, so having this bug here actually doesn't make much sense.

Closing as not our bug.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.