Created attachment 127631 [details] [review] Add LXDE and sylpheed support to xdg-email I attach a collection of patches from Ubuntu for xdg-screensaver and xdg-email. All appear to be relevant to current git. I describe the patches in their respective description fields.
Created attachment 127632 [details] [review] Write to .config/mimeapps.list as well as reading from it
Created attachment 127633 [details] [review] Fall back to mutt on generic desktop (if ~/.muttrc exists)
Created attachment 127634 [details] [review] Restore timeout when switching X screensaver back on
reviewing...
Comment on attachment 127631 [details] [review] Add LXDE and sylpheed support to xdg-email Review of attachment 127631 [details] [review]: ----------------------------------------------------------------- This one adds little value over open_generic (only adds 2 hard-coded fallbacks: thunderbird, sylpheed). I think I'd rather not carry that upstream
Comment on attachment 127632 [details] [review] Write to .config/mimeapps.list as well as reading from it Review of attachment 127632 [details] [review]: ----------------------------------------------------------------- This is nice, but it also removes support for applications/mimeapps.list, will have to investigate if any legacy DE's still require that
Comment on attachment 127633 [details] [review] Fall back to mutt on generic desktop (if ~/.muttrc exists) Review of attachment 127633 [details] [review]: ----------------------------------------------------------------- more hard-coded fallbacks, uses unknown/nonstandard x-terminal-emulator (what is that?)
Restore timeout when switching X screensaver back on patch applied, thanks.
Thanks for the review. I will make the point about hard-coded defaults to the Debian maintainers. However, I think you may have overlooked one thing: the LXDE patch is also generic, and adds support for a different DE (LXDE). So you could remove the hard-coded fallbacks and use the generic part.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xdg/xdg-utils/issues/97.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.