Bug 98509 - Patches from Ubuntu for xdg-{email,screensaver}
Summary: Patches from Ubuntu for xdg-{email,screensaver}
Status: ASSIGNED
Alias: None
Product: Portland
Classification: Unclassified
Component: xdg-utils (show other bugs)
Version: unspecified
Hardware: Other All
: medium enhancement
Assignee: Rex Dieter
QA Contact:
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-10-30 22:15 UTC by Reuben Thomas
Modified: 2017-03-01 10:01 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Add LXDE and sylpheed support to xdg-email (1.81 KB, patch)
2016-10-30 22:15 UTC, Reuben Thomas
Details | Splinter Review
Write to .config/mimeapps.list as well as reading from it (1.39 KB, patch)
2016-10-30 22:16 UTC, Reuben Thomas
Details | Splinter Review
Fall back to mutt on generic desktop (if ~/.muttrc exists) (531 bytes, patch)
2016-10-30 22:17 UTC, Reuben Thomas
Details | Splinter Review
Restore timeout when switching X screensaver back on (1.46 KB, patch)
2016-10-30 22:17 UTC, Reuben Thomas
Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Reuben Thomas 2016-10-30 22:15:22 UTC
Created attachment 127631 [details] [review]
Add LXDE and sylpheed support to xdg-email

I attach a collection of patches from Ubuntu for xdg-screensaver and xdg-email. All appear to be relevant to current git.

I describe the patches in their respective description fields.
Comment 1 Reuben Thomas 2016-10-30 22:16:16 UTC
Created attachment 127632 [details] [review]
Write to .config/mimeapps.list as well as reading from it
Comment 2 Reuben Thomas 2016-10-30 22:17:10 UTC
Created attachment 127633 [details] [review]
Fall back to mutt on generic desktop (if ~/.muttrc exists)
Comment 3 Reuben Thomas 2016-10-30 22:17:59 UTC
Created attachment 127634 [details] [review]
Restore timeout when switching X screensaver back on
Comment 4 Rex Dieter 2017-02-28 17:13:26 UTC
reviewing...
Comment 5 Rex Dieter 2017-02-28 17:23:41 UTC
Comment on attachment 127631 [details] [review]
Add LXDE and sylpheed support to xdg-email

Review of attachment 127631 [details] [review]:
-----------------------------------------------------------------

This one adds little value over open_generic (only adds 2 hard-coded fallbacks: thunderbird, sylpheed).  I think I'd rather not carry that upstream
Comment 6 Rex Dieter 2017-02-28 17:24:19 UTC
Comment on attachment 127632 [details] [review]
Write to .config/mimeapps.list as well as reading from it

Review of attachment 127632 [details] [review]:
-----------------------------------------------------------------

This is nice, but it also removes support for applications/mimeapps.list, will have to investigate if any legacy DE's still require that
Comment 7 Rex Dieter 2017-02-28 17:26:22 UTC
Comment on attachment 127633 [details] [review]
Fall back to mutt on generic desktop (if ~/.muttrc exists)

Review of attachment 127633 [details] [review]:
-----------------------------------------------------------------

more hard-coded fallbacks, uses unknown/nonstandard x-terminal-emulator (what is that?)
Comment 8 Rex Dieter 2017-02-28 17:30:58 UTC
Restore timeout when switching X screensaver back on patch applied, thanks.
Comment 9 Reuben Thomas 2017-03-01 10:01:26 UTC
Thanks for the review.

I will make the point about hard-coded defaults to the Debian maintainers.

However, I think you may have overlooked one thing: the LXDE patch is also generic, and adds support for a different DE (LXDE). So you could remove the hard-coded fallbacks and use the generic part.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.