Bug 9885 - Ambiguous kwd option in configure.ac
Summary: Ambiguous kwd option in configure.ac
Alias: None
Product: xorg
Classification: Unclassified
Component: App/compiz (show other bugs)
Version: 7.1 (2006.05)
Hardware: x86 (IA32) Linux (All)
: lowest trivial
Assignee: David Reveman
QA Contact:
Depends on:
Reported: 2007-02-05 20:13 UTC by Gerd Kohlberger
Modified: 2007-02-26 09:37 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Patch - disable kwd by default (611 bytes, patch)
2007-02-05 20:22 UTC, Gerd Kohlberger
no flags Details | Splinter Review

Description Gerd Kohlberger 2007-02-05 20:13:14 UTC

in configure.ac on line 333:

[  --disable-kde           Enable kde window decorator],
[use_kde=$enableval], [use_kde=yes])

I guess it should be --enable-kde and use_kde=no, or is it on purpose that both decorators are enabled by default?
Comment 1 Gerd Kohlberger 2007-02-05 20:22:42 UTC
Created attachment 8605 [details] [review]
Patch - disable kwd by default
Comment 2 David Reveman 2007-02-13 09:14:44 UTC
I don't see any reason why it should be disabled by default if all dependencies are available. Do you?
Comment 3 Gerd Kohlberger 2007-02-13 19:30:01 UTC
Well, since all gnome specific things are enabled by default, it would be consistent to disable kwd. If you have both qt & gtk headers installed, it will compile and install both decorators. Actually the patch was just a guess, because the configure option is wrong in either way (the description doesn't match the option).

It should be "--disable-kde  Disable kde window decorator" or "--enable-kde  Enable kde window decorator", not "--disable-kde Enable kde window decorator" like it is now.

Comment 4 David Reveman 2007-02-14 11:15:39 UTC
Yes, the description is wrong. I'll fix that.

I don't get why you think it would be consistent to disable kwd. I think it's consistent to enable both or disable both by default. There's no preferred decorator or desktop environment.
Comment 5 Gerd Kohlberger 2007-02-26 09:37:04 UTC
You're right, just wanted to make you aware of the typo. I'm closing this one.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.