Bug 98917 - [BDW SKL BSW KBL] Tessellation CTS tests regression
Summary: [BDW SKL BSW KBL] Tessellation CTS tests regression
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: high critical
Assignee: Timothy Arceri
QA Contact: Intel 3D Bugs Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-30 16:50 UTC by Mark Janes
Modified: 2016-11-30 23:27 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Janes 2016-11-30 16:50:46 UTC
Series ending in 2ea021a1ebb768b13c533f6bea56cdfb4a9cc3b3 regressed the following tests:

SKL    ES32-CTS.core.tessellation_shader.single.xfb_captures_data_from_correct_stage
ESEXT-CTS.tessellation_shader.single.xfb_captures_data_from_correct_stage
ES31-CTS.core.tessellation_shader.single.xfb_captures_data_from_correct_stage

BDW:
ESEXT-CTS.tessellation_shader.single.xfb_captures_data_from_correct_stage
ES31-CTS.core.tessellation_shader.single.xfb_captures_data_from_correct_stage

All failures are crashes.
Comment 1 Timothy Arceri 2016-11-30 23:27:08 UTC
Sorry about this not sure why I didn't see any failures. Fixed by:

commit 966567aa1296f99b16baec1ce92d64a8b3533d25
Author: Timothy Arceri <timothy.arceri@collabora.com>
Date:   Thu Dec 1 08:52:20 2016 +1100

    mesa: reset linked_stages bitmask when re-linking
    
    34953f8907fdd added this bitmask but it wasn't being reset when
    a program was relinked. If a stage was removed from the new
    program then it could case a crash as we expect the linked shader
    for that stage to not be null.
    
    Fixes crashes in:
    ESEXT-CTS.tessellation_shader.single.xfb_captures_data_from_correct_stage
    ES31-CTS.core.tessellation_shader.single.xfb_captures_data_from_correct_stage
    
    Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
    Reviewed-by: Dave Airlie <airlied@redhat.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98917


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.