Bug 98928 - [BXT] Mipi Screen remains blank after resuming from S3
Summary: [BXT] Mipi Screen remains blank after resuming from S3
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: XOrg git
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Mika Kahola
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-01 17:24 UTC by Luis Botello
Modified: 2017-02-20 12:46 UTC (History)
1 user (show)

See Also:
i915 platform: BXT
i915 features: display/DSI


Attachments
dmesg (161.88 KB, text/plain)
2017-01-05 22:42 UTC, Luis Botello
no flags Details
gpio file (336 bytes, text/plain)
2017-01-05 22:42 UTC, Luis Botello
no flags Details

Description Luis Botello 2016-12-01 17:24:31 UTC
Description:
=============================================
Mipi Screen remains blank after resuming from S3 state.

Steps to reproduce:
=============================================
Boot a BXT platform with MIPI panel, go to S3
#echo mem > /sys/power/state
Resume from S3 state by any method (keystroke,click,power button,etc)

Expected Result:
============================================
System resumes fine without any issue

Actual result:
============================================
MIPI screen remains blank after resuming from S3

HW Configuration:
==============================================
Platform : BXT-P
Motherboard model : BroxtonP
Motherboard type : NOTEBOOK Hand Held
Motherboard manufacturer : IntelCorp.
CPU family : Other
CPU information : 06/5c
GPU Card : Intel Corporation Device 5a84 (rev 0a) (prog-if 00 [VGA controller])
Screen	: AUO 10.1" 1920x1200 Non-Touch MIPI Kit - B101UAN01.7

SW Configuration:
===============================================
Kernel
commit d6149d212b69a8e1d9229fe80fca034a0abe1d0e
Author: Mika Kuoppala <mika.kuoppala@intel.com>
Date: Mon Nov 21 14:48:58 2016 +0200
drm-intel-nightly: 2016y-11m-21d-12h-48m-13s UTC integration manifest
Component : drm
tag : libdrm-2.4.73-9-g1924b67
commit : 1924b67 
Component : mesa
tag : 13.0-branchpoint-931-g7a2cfd4
commit : 7a2cfd4 
Component : xf86-video-intel
tag : 2.99.917-736-gbde9460
commit : bde9460 
Component : libva
tag : libva-1.7.2-44-g598fb9e
commit : 598fb9e 
Component : intel-driver
tag : 1.7.2-189-gce55d7e
commit : ce55d7e 
Component : cairo
tag : 1.15.2-75-g3f1a6f7
commit : 3f1a6f7 
Component : xserver
tag : xorg-server-1.19.0-3-gcf88607
commit : cf88607 
Component : macros
tag : util-macros-1.19.0-2-gd7acec2
commit : d7acec2 
Component : intel-gpu-tools
tag : intel-gpu-tools-1.16-156-gcddf996
commit : cddf996 
Component : rendercheck
tag : rendercheck-1.5-9-g44032a7
commit : 44032a7

Additional Info:
===================================================
Dmesg relevant information:
[  109.243947] [drm:generic_exec_sequence [i915]] Starting MIPI sequence 10 - MIPI_SEQ_POWER_ON
[  109.244012] [drm:mipi_exec_gpio [i915]] 
[  109.244035] [drm:mipi_exec_gpio [i915]] GPIO element not supported on this platform
[  109.244058] [drm:mipi_exec_delay [i915]] 
[  109.249309] [drm:intel_dsi_pre_enable [i915]] 
[  109.383519] [drm:dpi_send_cmd.constprop.8 [i915]] *ERROR* Video mode command 0x00000042 send failed.

These IGT tests are also failing dur to the same issue:
kms_pipe_crc_basic@suspend-read-crc-pipe-a -> dmesg-fail
kms_pipe_crc_basic@suspend-read-crc-pipe-b -> dmesg-fail
kms_pipe_crc_basic@suspend-read-crc-pipe-c -> dmesg-fail
gem_exec_suspend@basic-s3 -> fail
Comment 1 Jani Nikula 2016-12-05 10:53:55 UTC
Please try this series on top of v4.9-rc8 or drm-tip branch of https://cgit.freedesktop.org/drm-tip

https://patchwork.freedesktop.org/series/16242/
Comment 2 Jani Saarinen 2016-12-13 15:07:07 UTC
Please test latest drm-tip as 2 patches now needed landed.
Comment 3 Luis Botello 2016-12-20 19:02:18 UTC
(In reply to Jani Saarinen from comment #2)
> Please test latest drm-tip as 2 patches now needed landed.

Hi Jani I tried to apply that series but the patches was not applied successfully, could you please provide a new rebased series, or share a workarruound to apply them?

As additional comment, I tested with the latest drm-intel-tip commit available and issue is still present
Comment 4 Luis Botello 2016-12-20 19:03:28 UTC
Adding commit tested:

commit 6096aee14ea52e3163729129ee7362e56ff3efb9
Author: Rodrigo Vivi <rodrigo.vivi@intel.com>
Date:   Tue Dec 20 08:33:39 2016 -0800

    drm-tip: 2016y-12m-20d-16h-33m-17s UTC integration manifest
Comment 5 Luis Botello 2017-01-03 22:18:45 UTC
This issue is still present on APL MIPI with the latest drm-tip, after resuming from S3, MIPI screen remains blank, dmesg has the same issues previously mentioned.

This is the commit tested:

commit bcc5c7c32d36f7d59503a0c812401d013d372517
Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Date:   Tue Jan 3 15:43:13 2017 +0200

    drm-tip: 2017y-01m-03d-13h-42m-11s UTC integration manifest
Comment 6 Luis Botello 2017-01-05 22:42:04 UTC
The issue is still seen, I have tested this drm-tip kernel:

commit 8e6dfeed0f95b5f85430271a46d2f817a6df1d21
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Thu Jan 5 16:48:57 2017 +0000
drm-tip: 2017y-01m-05d-16h-48m-32s UTC integration manifest

This config CONFIG_PINCTRL_BROXTON=y is also set.

Adding dmesg and gpio file.
Comment 7 Luis Botello 2017-01-05 22:42:22 UTC
Created attachment 128786 [details]
dmesg
Comment 8 Luis Botello 2017-01-05 22:42:40 UTC
Created attachment 128787 [details]
gpio file
Comment 9 Luis Botello 2017-01-10 20:54:53 UTC
I have tested drm-tip & mika branch, both branches work fine after applying this patches series:

https://patchwork.freedesktop.org/patch/131945/

These are the commits tested:

drm-tip:
commit 213063f5a323e24496735f7968221080851ae361
Author: Vidya Srinivas <vidya.srinivas@intel.com>
Date: Mon Jan 9 14:46:29 2017 +0530
drm/i915: Enable VBT backlight sequences
Enable the support for backlight sequences to configure
backlight settings based on VBT Backlight on/off sequence.
Signed-off-by: Uma Shankar <uma.shankar@intel.com>
-----------------------------------------------------------------------

drm-intel-mika:
commit 1565c11768de92b946bccb27b9486db09de41bf1
Author: Vidya Srinivas <vidya.srinivas@intel.com>
Date: Mon Jan 9 14:46:29 2017 +0530
drm/i915: Enable VBT backlight sequences
Enable the support for backlight sequences to configure
backlight settings based on VBT Backlight on/off sequence.
Signed-off-by: Uma Shankar <uma.shankar@intel.com>

gem_exec_suspend/basic-S3 -> PASS
gem_exec_suspend/basic-S4 -> PASS
testdisplay -a -> PASS
Comment 10 cprigent 2017-01-16 09:53:46 UTC
Let's keep it open and do a final verification when the patch is upstream.
Mika, can you tell to Luis when this patch is pushed upstream?
Comment 11 Jani Nikula 2017-01-16 10:02:05 UTC
(In reply to cprigent from comment #10)
> Let's keep it open and do a final verification when the patch is upstream.

Reopened, I don't think the patches have been merged, still under review.
Comment 12 Mika Kahola 2017-02-14 07:37:23 UTC
Resolving this one. The patch has been reviewed and pushed upstream.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.