Bug 98931 - radeonsi: Very low shader performance
Summary: radeonsi: Very low shader performance
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/Gallium/radeonsi (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Default DRI bug account
QA Contact: Default DRI bug account
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-02 04:17 UTC by Cris
Modified: 2017-02-15 16:25 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Cris 2016-12-02 04:17:51 UTC
This shader https://gist.github.com/igv/a015fc885d5c22e6891820ad89555637 (5th of September revision, crossbilateral only) used to crash the radeon driver and bring the whole system down, whilst the previous version did not. 
After this was magically fixed, the only issue has been extremely low performance, visible through low render times and a few dropped frames.

Test case: https://www.youtube.com/watch?v=6v2L2UGZJAM (it is important that you use my settings for the 1080p version to be selected)

Using any revision of this shader after the introduction of the 5th of September commit, on mpv, I get render times in the order of 31000 and lots of dropped, mistimed frames (as per lua-stats). Using the version immediately before this one ( https://gist.github.com/igv/a015fc885d5c22e6891820ad89555637/15a6623d61b4030ed4d8dce637e509b7433f39c2 ) I get 6700 on the same video.

CPU+GPU: i5-4690, R9-280x
mpv, ffmpeg, mesa, llvm and xf86-video-ati are all git.

SSIMsuperres can be found here https://gist.github.com/igv/2364ffa6e81540f29cb7ab4c9bc05b6b
Relevant bits of mpv.conf for reproduction purposes:


profile=opengl-hq
opengl-pbo=yes

# Scaling
scale=ewa_lanczossharp
opengl-shaders="~~/shaders/ssimsuperres.glsl,~~/shaders/crossbilateral.glsl" #cscale

# Interpolation
tscale=sinc
interpolation=yes
video-sync=display-resample
tscale-clamp=yes

# Misc
temporal-dither=yes
dither-depth=8
deband-iterations=2
deband-range=12
blend-subtitles=no
hwdec=no
framedrop=vo

# Web media
ytdl=yes
ytdl-format=0/(bestvideo[vcodec=vp9]/bestvideo[height>720]/bestvideo[fps>30])[tbr<13000]+(bestaudio[acodec=opus]/bestaudio)/best
Comment 1 Cris 2017-02-15 16:25:01 UTC
No idea what fixed it, but it's working just fine now.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.