Bug 99142 - Not releasing/cleaning up clients by wl_client_destroy() upon wl_display_destroy()
Summary: Not releasing/cleaning up clients by wl_client_destroy() upon wl_display_dest...
Status: RESOLVED MOVED
Alias: None
Product: Wayland
Classification: Unclassified
Component: wayland (show other bugs)
Version: unspecified
Hardware: Other All
: high critical
Assignee: Wayland bug list
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-19 07:38 UTC by Vivek.A
Modified: 2018-06-08 23:49 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Patch (595 bytes, patch)
2016-12-19 07:40 UTC, Vivek.A
Details | Splinter Review

Description Vivek.A 2016-12-19 07:38:04 UTC
This causes all the file descriptors to be kept open till the process hosting the compositor is terminated / exit. So the client side we can't monitor if the compositor has terminated (i.e by checking the display->fd).

This problem is observed when running/contolling compositor as a separate thread.
Comment 1 Vivek.A 2016-12-19 07:40:58 UTC
Created attachment 128537 [details] [review]
Patch
Comment 2 Pekka Paalanen 2016-12-19 08:04:39 UTC
Hi,

please send patches to the mailing list where they can be reviewed:
https://cgit.freedesktop.org/wayland/wayland/tree/doc/Contributing

Add a proper commit message, reference to this bug, and a signed-off-by line.


Thanks.
Comment 3 Vivek.A 2016-12-20 13:14:27 UTC
Added patch set : https://patchwork.freedesktop.org/patch/128832/
Comment 4 Pekka Paalanen 2016-12-20 13:28:35 UTC
Nice, thanks!
Comment 5 Vivek.A 2016-12-20 13:37:54 UTC
thanks to you, for the direction.
Comment 6 Vivek.A 2017-01-23 08:47:46 UTC
Hi, Is there anything else I need to do to get this reviewed?
Comment 7 emersion 2017-12-11 21:57:28 UTC
Added patch set: https://patchwork.freedesktop.org/patch/192860/
Comment 8 GitLab Migration User 2018-06-08 23:49:55 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/wayland/wayland/issues/36.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.