Created attachment 128940 [details]
Author: Alejandro Piñeiro <email@example.com>
AuthorDate: Thu Jan 12 16:03:00 2017 -0200
Commit: Alejandro Piñeiro <firstname.lastname@example.org>
CommitDate: Fri Jan 13 08:52:07 2017 -0200
Parent: 963311b mesa/main: fix version/extension checks in _mesa_ClampColor
Follows: 13.0-branchpoint (2236)
main/fboject: return if it is color_attachment on get_attachment
Reviewed-by: Nicolai Hähnle <email@example.com>
G33 is not in the developer pool for CI tests (machines too rare and too slow), so Alejandro could not have seen this before pushing.
FYI, G33 uses i915_dri.so, not i965_dri.so. Pretty much any hardware which uses that older driver would probably reproduce this.
My bisection was incorrect. The tests regressed at the previous commit:
Author: Nicolai Hähnle <firstname.lastname@example.org>
mesa/main: fix version/extension checks in _mesa_ClampColor
That test doesn't call glClampColor (and if it did, that would be incorrect). So that's odd.
Does i915 use some of the meta code? That might be calling _mesa_ClampColor without proper checking.
Created attachment 128979 [details] [review]
Of all the internal callers of _mesa_ClampColor, there's one that isn't properly guarded, and that piglit test should hit it -- so the attached patch should fix this, but please test and confirm on i915. Thanks!
Nicolai's patch fixes the test for me.
fixed by a7c635ec6589f600f0d52d0097774ea0b938de9f
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct.