Bug 99461 - Xwinsock.h does not compile on 64-bit Windows.
Summary: Xwinsock.h does not compile on 64-bit Windows.
Status: RESOLVED MOVED
Alias: None
Product: xorg
Classification: Unclassified
Component: Protocol/Core (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Windows (All)
: medium major
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-19 15:34 UTC by Peter Williams
Modified: 2018-08-10 19:55 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Attempt to fix INT64 name clash. (404 bytes, patch)
2017-01-19 15:34 UTC, Peter Williams 		no flags Details | Splinter Review
Patch, version 2 (1.14 KB, patch)
2017-01-19 18:49 UTC, Peter Williams 		no flags Details | Splinter Review
Show Obsolete (1) View All

Description Peter Williams 2017-01-19 15:34:29 UTC 
Created attachment 129047 [details] [review]
Attempt to fix INT64 name clash.

If you try to compile a C file using Xwinsock.h (e.g., libXdmcp/Fill.c), you get a compilation failure since the Windows-related name mangling seems not to have been updated for the existence of 64-bit Windows: there's a name clash on INT64 between X Windows and Microsoft Windows. I'm hopeful that the attached patch fixes the problem, although I haven't yet finished a new build.
Comment 1 Peter Williams 2017-01-19 18:49:06 UTC 
Created attachment 129053 [details] [review]
Patch, version 2

It turns out the identifier LONG64 caused further problems. I got the build to work with this patch.
Comment 2 GitLab Migration User 2018-08-10 19:55:20 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xorg/proto/xorgproto/issues/6.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.