Bug 99570 - Allow screen rotation in virt-viewer
Summary: Allow screen rotation in virt-viewer
Status: RESOLVED NOTABUG
Alias: None
Product: Spice
Classification: Unclassified
Component: virt-viewer (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Spice Bug List
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-27 20:05 UTC by Maciej Piechotka
Modified: 2017-07-01 17:40 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Maciej Piechotka 2017-01-27 20:05:18 UTC
When I try to change resolution to portrait in Windows settings screen is rotated by π/2. It would be nice if it was possible to fix it by correcting rotation inside virt-viewer.
Comment 1 Victor Toso 2017-06-30 14:14:19 UTC
This is by design and I can't see a good use case to support rotating the widget.
Comment 2 Eduardo Lima (Etrunko) 2017-06-30 14:49:40 UTC
Wouldn't this be a feature of the driver?
Comment 3 Victor Toso 2017-06-30 15:27:58 UTC
(In reply to Eduardo Lima (Etrunko) from comment #2)
> Wouldn't this be a feature of the driver?

How so? AFAIU, you changed correctly the guest to rotate-left, it shows the widget correctly. The request is that we should change the widget to rotate too.
Comment 4 Eduardo Lima (Etrunko) 2017-06-30 15:39:34 UTC
(In reply to Victor Toso from comment #3)
> (In reply to Eduardo Lima (Etrunko) from comment #2)
> > Wouldn't this be a feature of the driver?
> 
> How so? AFAIU, you changed correctly the guest to rotate-left, it shows the
> widget correctly. The request is that we should change the widget to rotate
> too.

I am not sure how it works in this case, but I think the widget does not need to know the orientation of the buffer, only the dimensions. The driver should then handle the change properly.
Comment 5 Pavel Grunt 2017-06-30 15:49:03 UTC
Maciej, do you have spice agent installed? https://www.spice-space.org/download/windows/spice-guest-tools/spice-guest-tools-latest.exe

The agent adjusts resolution per virt-viewer's window dimensions.
Comment 6 Victor Toso 2017-07-01 13:12:18 UTC
Confused.

For me, the behavior that we have is what it is expected. The guest screen rotates in the widget. Go full screen and rotate client's physical monitor to make it vertical, not Spice's widget.

I don't see any real use case to make Spice display to rotate to follow guest's orientation.
Comment 7 Maciej Piechotka 2017-07-01 17:40:45 UTC
(In reply to Pavel Grunt from comment #5)
> Maciej, do you have spice agent installed?
> https://www.spice-space.org/download/windows/spice-guest-tools/spice-guest-
> tools-latest.exe
> 
> The agent adjusts resolution per virt-viewer's window dimensions.

No and I cannot as it does not support Windows Server.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.