Bug 99577 - Please use security-medium icon instead of stock_lock one
Summary: Please use security-medium icon instead of stock_lock one
Status: RESOLVED FIXED
Alias: None
Product: PulseAudio
Classification: Unclassified
Component: pavucontrol (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: pulseaudio-bugs
QA Contact: pulseaudio-bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-28 12:34 UTC by Laurent Bigonville
Modified: 2017-03-15 21:55 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
Patch (1.54 KB, patch)
2017-01-28 12:34 UTC, Laurent Bigonville 		Details | Splinter Review
View All

Description Laurent Bigonville 2017-01-28 12:34:21 UTC 
Created attachment 129194 [details] [review]
Patch

Hi,

pavucontrol currently uses the stock_lock icon which is not part of the freedesktop theme and it's not part of the default gtk3 icon theme (adwaita)

Fedora has the attached patch applied to their package for quite sometimes now.

Could you please merge it?

See: https://bugzilla.redhat.com/show_bug.cgi?id=1249198
Comment 1 Tanu Kaskinen 2017-01-31 13:27:47 UTC 
Thanks! Applied.
Comment 2 Arun Raghavan 2017-03-15 10:53:58 UTC 
From Github:

> palinek 14 minutes ago
> 
> Just a note: the "changes-prevent" XDG symbolic name would be better. It's used
> in the qt port (https://github.com/lxde/pavucontrol-qt/commit/eb64605edbc2badea452ff0d6d387c547302159b)
Comment 3 Laurent Bigonville 2017-03-15 10:56:46 UTC 
(In reply to Arun Raghavan from comment #2)
> From Github:
> 
> > palinek 14 minutes ago
> > 
> > Just a note: the "changes-prevent" XDG symbolic name would be better. It's used
> > in the qt port (https://github.com/lxde/pavucontrol-qt/commit/eb64605edbc2badea452ff0d6d387c547302159b)

Yeah that icon is indeed maybe better

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.