Bug 99593 - Messages with the same time stamp get their order reversed
Summary: Messages with the same time stamp get their order reversed
Status: RESOLVED MOVED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: logger (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-29 17:41 UTC by Daniel Landau
Modified: 2019-12-03 19:32 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
Fix (1.15 KB, patch)
2017-01-29 17:41 UTC, Daniel Landau 		Details | Splinter Review
Typo fixed patch (1.15 KB, patch)
2017-01-31 15:00 UTC, Daniel Landau 		Details | Splinter Review
View All

Description Daniel Landau 2017-01-29 17:41:31 UTC 
Created attachment 129217 [details] [review]
Fix

Telepathy-logger exactly reverses the order of pending messages that arrive at the exact same timestamp. This situation arises when using a bouncer that has buffered messages while the user is offline. The core issue is that the code gets the messages in order, goes through them one by one, prepending them to a new list. This list needs to be reversed to reobtain the original order. The attached patch does that.

This bug has been filed against Polari: https://bugzilla.gnome.org/show_bug.cgi?id=773201
Comment 1 Daniel Landau 2017-01-31 15:00:21 UTC 
Created attachment 129258 [details] [review]
Typo fixed patch
Comment 2 GitLab Migration User 2019-12-03 19:32:43 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-logger/issues/45.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.