Bug 99600 - typo: x-cetrificate-value
Summary: typo: x-cetrificate-value
Status: RESOLVED FIXED
Alias: None
Product: p11-glue
Classification: Unclassified
Component: p11-kit (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Stef Walter
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-30 12:04 UTC by Kai Engert
Modified: 2017-02-17 09:18 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Kai Engert 2017-01-30 12:04:48 UTC 
./common/constants.c:	CT (CKA_X_CERTIFICATE_VALUE, "x-cetrificate-value")

Note the id says ceTRificate, not ceRTificate.

Do you think anyone is using this identifier already? If yes, is it too late to change it? Do you need a backwards compatibility alias?

I must use this value in code related to bug 99453 soon. My work will require a newer version of p11-kit, so in theory it could use the fixed identifier. I just would prefer to not have to change it later.
Comment 1 Stef Walter 2017-01-31 16:37:51 UTC 
Good catch. I don't think this one is in wide use yet. I would go ahead and change it to be honest.
Comment 2 Kai Engert 2017-02-02 15:10:49 UTC 
Added to this pull request:
https://github.com/p11-glue/p11-kit/pull/46
Comment 3 Daiki Ueno 2017-02-17 09:18:38 UTC 
This has been merged as part of PR#46.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.