Bugzilla – Bug 9965
on Unichrome an accelerated window is displayed at double coordinates of window itself
Last modified: 2009-08-24 12:25:53 UTC
Bisecting shows that this bug was introduced with commit d7815f59134b0fb5cb3b56b72b22ba55002265ac.
The bug is most clear when slowly moving a glxgears window from the upperleft corner vertically down or horizontally to the right. The gears themselves move with the window, but the "viewport" moves twice as fast (picking up an echo of the gears some 400 pixels to the right).
Where did this bug go? I haven't seen it yet on dri-devel or mesa3d-dev.
Created attachment 8832 [details] [review]
patch by Miguel Marte that fixes the problem
Same patch as submitted for review by Miguel Marte in this email:
Created attachment 8848 [details] [review]
be consistent to avoid doubling up
At comment #3: this new patch is not as good as the previous one. After applying it (and tweaking it to make it compile), the gears in glxgears are "gnawed" to bits (at certain x positions), and are located at double the coordinates of the window itself.
CC'ing Miguel. See previous comment.
Created attachment 8856 [details] [review]
real fix, was working on makecurrent read and sent in the wrong one
This should do it :\ sorry for the wrong file. Can some one tell me why we are even using orig to begin with?
Created attachment 8857 [details] [review]
diff to current git
Created attachment 8918 [details] [review]
kill off the rest of drawXoff, apply prev patch first
Kill off the rest of drawXoff, its still affecting the back buffer -> front buffer. This will fix the offset problems in texenv,gearbox and hopefully the problem Xavier has with the screensaver preview. One question that i have is, is the first box in gearbox suppose to be the depth buffer?
Created attachment 8961 [details] [review]
remove all uses of Xdrawoffset from unichrome driver
Combines the last two patches by Miguel, plus a parentheses fix and obsolete comment removal.
I've checked in the last patch. Can this be closed now?
Brian: I can't find the commit, could you give the id?
At comment #13: c41d6ab6f062ebce1076ca79f9ad0c7368a0e2d0
*** Bug 11762 has been marked as a duplicate of this bug. ***
Mass version move, cvs -> git