Created attachment 129301 [details] [review] patch for spporting mime-type for fds files The Famicom Disk System was a Japan-exclusive storage device for the Famicom, designed to reduce Nintendo's cost of making copies of games.The mime-type for fds files are not yet supported by shared-mime-info.
Comment on attachment 129301 [details] [review] patch for spporting mime-type for fds files Review of attachment 129301 [details] [review]: ----------------------------------------------------------------- ::: freedesktop.org.xml.in @@ +6984,5 @@ > <glob pattern="*.gcode"/> > </mime-type> > > + <mime-type type="application/x-fds-rom"> > + <comment>FDS ROM</comment> This isn't marked for translation, and also lacks the acronym expansion. ::: tests/list @@ +505,4 @@ > neo-geo-pocket-test.ngp application/x-neo-geo-pocket-rom > # Pac-Man from Atari 2600 truncated to 1Ko > atari-2600-test.A26 application/x-atari-2600-rom ox > +#Metroid truncated to 1Ko Space after "#" like in the other lines.
Created attachment 129315 [details] [review] add mime type for fds files
Comment on attachment 129315 [details] [review] add mime type for fds files Review of attachment 129315 [details] [review]: ----------------------------------------------------------------- It almost looks good to me. ::: freedesktop.org.xml.in @@ +6984,4 @@ > <glob pattern="*.gcode"/> > </mime-type> > > + <mime-type type="application/x-fds"> Question for Bastien: wouldn't application/x-fds-disk be better? @@ +6984,5 @@ > <glob pattern="*.gcode"/> > </mime-type> > > + <mime-type type="application/x-fds"> > + <_comment>fds file</_comment> The comment isn't good, take inspiration form other MIME types: it should be explicit and descriptive yet short. ::: tests/list @@ +505,5 @@ > neo-geo-pocket-test.ngp application/x-neo-geo-pocket-rom > # Pac-Man from Atari 2600 truncated to 1Ko > atari-2600-test.A26 application/x-atari-2600-rom ox > +# Metroid truncated to 1Ko > +Metroid_japan.fds application/x-fds It doesn't look like the patch adds the Metroid_japan.fds file.
(In reply to Adrien Plazas from comment #3) > Comment on attachment 129315 [details] [review] [review] > add mime type for fds files > > Review of attachment 129315 [details] [review] [review]: > ----------------------------------------------------------------- > > It almost looks good to me. > > ::: freedesktop.org.xml.in > @@ +6984,4 @@ > > <glob pattern="*.gcode"/> > > </mime-type> > > > > + <mime-type type="application/x-fds"> > > Question for Bastien: wouldn't application/x-fds-disk be better? Yes, it would be better. > @@ +6984,5 @@ > > <glob pattern="*.gcode"/> > > </mime-type> > > > > + <mime-type type="application/x-fds"> > > + <_comment>fds file</_comment> > > The comment isn't good, take inspiration form other MIME types: it should be > explicit and descriptive yet short. > > ::: tests/list > @@ +505,5 @@ > > neo-geo-pocket-test.ngp application/x-neo-geo-pocket-rom > > # Pac-Man from Atari 2600 truncated to 1Ko > > atari-2600-test.A26 application/x-atari-2600-rom ox > > +# Metroid truncated to 1Ko > > +Metroid_japan.fds application/x-fds > > It doesn't look like the patch adds the Metroid_japan.fds file. It does, they don't show up in splinter.
Created attachment 129347 [details] [review] The Famicom Disk System was a Japan-exclusive storage device for the Famicom, designed to reduce Nintendo's cost of making copies of games.
Committed as 67d566c10ce4aba1e467f3af82d9770b040b6e88
Comment on attachment 129347 [details] [review] The Famicom Disk System was a Japan-exclusive storage device for the Famicom, designed to reduce Nintendo's cost of making copies of games. Review of attachment 129347 [details] [review]: ----------------------------------------------------------------- Besides the comment it looks good to me. ::: freedesktop.org.xml.in @@ +6984,5 @@ > <glob pattern="*.gcode"/> > </mime-type> > > + <mime-type type="application/x-fds-disk"> > + <_comment>fds file</_comment> This is not a comment, look at other MIME types to understand what it's supposed to be.
Yes i saw various mime-types and the comments used for them .I found this as the most suitable. If you think its not that good you may suggest,i will change it.
(In reply to radhika from comment #8) > Yes i saw various mime-types and the comments used for them .I found this as > the most suitable. If you think its not that good you may suggest,i will > change it. It was bad, but I changed it already. See: https://cgit.freedesktop.org/xdg/shared-mime-info/commit/?id=67d566c10ce4aba1e467f3af82d9770b040b6e88
(In reply to Bastien Nocera from comment #9) > (In reply to radhika from comment #8) > > Yes i saw various mime-types and the comments used for them .I found this as > > the most suitable. If you think its not that good you may suggest,i will > > change it. > > It was bad, but I changed it already. See: > https://cgit.freedesktop.org/xdg/shared-mime-info/commit/ > ?id=67d566c10ce4aba1e467f3af82d9770b040b6e88 I am really sorry.Although i tried my best,yet i could not find a good comment. Thanks for changing it.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.