Bug 99729 - [APL] [BAT] igt@gem_exec_fence@await-hang-default fails on CI
Summary: [APL] [BAT] igt@gem_exec_fence@await-hang-default fails on CI
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: DRI git
Hardware: x86-64 (AMD64) All
: medium major
Assignee: Intel GFX Bugs mailing list
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-09 12:45 UTC by Jani Saarinen
Modified: 2017-02-16 14:48 UTC (History)
1 user (show)

See Also:
i915 platform: BXT
i915 features: GEM/Other


Attachments

Description Jani Saarinen 2017-02-09 12:45:49 UTC
igt@gem_exec_fence@await-hang-default failed once on CI
https://intel-gfx-ci.01.org/CI/CI_DRM_2163/fi-bxt-j4205/igt@gem_exec_fence@await-hang-default.html
Comment 1 Chris Wilson 2017-02-09 13:07:32 UTC
Should be fixed:

commit 1f7b847d72c3583df5048d83bd945d0c2c524c28
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Wed Feb 8 14:30:33 2017 +0000

    drm/i915: Disable engine->irq_tasklet around resets
    
    When we restart the engines, and we have active requests, a request on
    the first engine may complete and queue a request to the second engine
    before we try to restart the second engine. That queueing of the
    request may race with the engine to restart, and so may corrupt the
    current state. Disabling the engine->irq_tasklet prevents the two paths
    from writing into ELSP simultaneously (and modifyin the execlists_port[]
    at the same time).
    
    Fixes: 821ed7df6e2a ("drm/i915: Update reset path to fix incomplete requests
")
    Testcase: igt/gem_exec_fence/await-hang
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
    Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
    Cc: Mika Kuoppala <mika.kuoppala@intel.com>
    Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>
    Link: http://patchwork.freedesktop.org/patch/msgid/20170208143033.11651-3-ch
ris@chris-wilson.co.uk
Comment 2 Jani Saarinen 2017-02-10 13:19:03 UTC
This bug was about APL but was fix general all platforms?
for this igt@gem_exec_fence@await-hang-default test?
Comment 3 Chris Wilson 2017-02-10 14:08:16 UTC
For this bug, it is common to execlists.
Comment 4 Jani Saarinen 2017-02-13 14:23:53 UTC
Do you consider all of these to be closed?
FDO#99733
FDO#99726
FDO#99725
FDO#99729
Comment 5 Jani Saarinen 2017-02-13 14:24:28 UTC
For this test: igt@gem_exec_fence@await-hang-default I mean.
Comment 6 Chris Wilson 2017-02-13 14:32:55 UTC
bug 99726 is unresolved, on hsw so not this patch (this patch is execlists only), and there's not enough information there to ascertain the cause.

bug 99725 is a mismash, of which the await-hang-default fail might be this but an invisible link.

bug 99733 had a different root cause, should be fixed by the patch given there.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.