Bug 103166

Summary: [CI] igt@kms_plane-*@* - Failed CRC mismatch
Product: DRI Reporter: Marta Löfstedt <marta.lofstedt>
Component: DRM/IntelAssignee: Mika Kahola <mika.kahola>
Status: CLOSED INVALID QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: normal    
Priority: high CC: intel-gfx-bugs, lakshminarayana.vudum, mika.kahola
Version: DRI git   
Hardware: Other   
OS: All   
Whiteboard: ReadyForDev
i915 platform: BXT, CFL, ICL, ILK, KBL, SKL, SNB i915 features: display/Other
Bug Depends on:    
Bug Blocks: 105978    

Description Marta Löfstedt 2017-10-09 12:42:40 UTC
On CI_DRM_3191 APL-shards fail igt@kms_plane@plane-panning-bottom-right-pipe-B-planes:

(kms_plane:1518) igt-debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file igt_debugfs.c:346:
(kms_plane:1518) igt-debugfs-CRITICAL: Failed assertion: !mismatch
Subtest plane-panning-bottom-right-pipe-B-planes failed.


https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3191/shard-apl4/igt@kms_plane@plane-panning-bottom-right-pipe-B-planes.html
Comment 1 Marta Löfstedt 2017-10-31 08:53:14 UTC
new subtest on:
CI_DRM_3294 shard-apl7 igt@kms_plane@plane-panning-bottom-right-suspend-pipe-C-planes

(kms_plane:3483) igt-debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file igt_debugfs.c:346:
(kms_plane:3483) igt-debugfs-CRITICAL: Failed assertion: !mismatch
Subtest plane-panning-bottom-right-suspend-pipe-C-planes failed.

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3294/shard-apl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-C-planes.html
Comment 2 Marta Löfstedt 2017-11-07 06:46:20 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3317/shard-apl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html

(kms_plane:1686) igt-debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file igt_debugfs.c:346:
(kms_plane:1686) igt-debugfs-CRITICAL: Failed assertion: !mismatch
Subtest plane-panning-bottom-right-suspend-pipe-A-planes failed.
Comment 3 Marta Löfstedt 2017-11-21 07:57:35 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3365/shard-apl5/igt@kms_plane@plane-position-hole-pipe-a-planes.html

(kms_plane:1629) igt-debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file igt_debugfs.c:353:
(kms_plane:1629) igt-debugfs-CRITICAL: Failed assertion: !mismatch
Subtest plane-position-hole-pipe-A-planes failed.
Comment 4 Marta Löfstedt 2017-11-29 12:25:53 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3404/shard-apl1/igt@kms_plane@plane-position-hole-pipe-c-planes.html

(kms_plane:2643) igt-debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file igt_debugfs.c:356:
(kms_plane:2643) igt-debugfs-CRITICAL: Failed assertion: !mismatch
Subtest plane-position-hole-pipe-C-planes failed.
Comment 5 Marta Löfstedt 2017-11-30 07:44:00 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4025/shard-apl8/igt@kms_plane_multiple@legacy-pipe-a-tiling-none.html

(kms_plane_multiple:14249) igt-debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file igt_debugfs.c:356:
(kms_plane_multiple:14249) igt-debugfs-CRITICAL: Failed assertion: !mismatch
(kms_plane_multiple:14249) igt-debugfs-CRITICAL: Last errno: 25, Inappropriate ioctl for device
Subtest legacy-pipe-A-tiling-none failed.
Comment 6 Marta Löfstedt 2017-12-07 09:03:08 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4040/shard-apl2/igt@kms_plane_multiple@atomic-pipe-c-tiling-none.html

(kms_plane_multiple:1479) igt-debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file igt_debugfs.c:356:
(kms_plane_multiple:1479) igt-debugfs-CRITICAL: Failed assertion: !mismatch
(kms_plane_multiple:1479) igt-debugfs-CRITICAL: Last errno: 25, Inappropriate ioctl for device
Subtest atomic-pipe-C-tiling-none failed.
Comment 7 Marta Löfstedt 2017-12-08 07:14:57 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3476/shard-apl7/igt@kms_plane_multiple@legacy-pipe-b-tiling-none.html

(kms_plane_multiple:1491) igt-debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file igt_debugfs.c:356:
(kms_plane_multiple:1491) igt-debugfs-CRITICAL: Failed assertion: !mismatch
(kms_plane_multiple:1491) igt-debugfs-CRITICAL: Last errno: 25, Inappropriate ioctl for device
Subtest legacy-pipe-B-tiling-none failed.
Comment 8 Marta Löfstedt 2017-12-14 06:54:17 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3511/shard-apl8/igt@kms_plane_lowres@pipe-c-tiling-x.html
	

(kms_plane_lowres:3091) igt-debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file igt_debugfs.c:356:
(kms_plane_lowres:3091) igt-debugfs-CRITICAL: Failed assertion: !mismatch
(kms_plane_lowres:3091) igt-debugfs-CRITICAL: Last errno: 9, Bad file descriptor
Subtest pipe-C-tiling-x failed.

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3508/shard-apl6/igt@kms_plane_lowres@pipe-c-tiling-yf.html


(kms_plane_lowres:1533) igt-debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file igt_debugfs.c:356:
(kms_plane_lowres:1533) igt-debugfs-CRITICAL: Failed assertion: !mismatch
(kms_plane_lowres:1533) igt-debugfs-CRITICAL: Last errno: 9, Bad file descriptor
Subtest pipe-C-tiling-yf failed.
Comment 9 Marta Löfstedt 2017-12-18 08:22:01 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4067/shard-apl4/igt@kms_plane@plane-panning-bottom-right-pipe-a-planes.html

(kms_plane:1828) igt-debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file igt_debugfs.c:356:
(kms_plane:1828) igt-debugfs-CRITICAL: Failed assertion: !mismatch
Subtest plane-panning-bottom-right-pipe-A-planes failed.
Comment 10 Marta Löfstedt 2018-01-04 13:47:14 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4113/shard-apl3/igt@kms_plane_lowres@pipe-b-tiling-y.html

(kms_plane_lowres:1509) igt-debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file igt_debugfs.c:356:
(kms_plane_lowres:1509) igt-debugfs-CRITICAL: Failed assertion: !mismatch
(kms_plane_lowres:1509) igt-debugfs-CRITICAL: Last errno: 9, Bad file descriptor
Subtest pipe-B-tiling-y failed.
Comment 11 Marta Löfstedt 2018-01-05 06:45:16 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3602/shard-apl1/igt@kms_plane_lowres@pipe-c-tiling-y.html

(kms_plane_lowres:1482) igt-debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file igt_debugfs.c:356:
(kms_plane_lowres:1482) igt-debugfs-CRITICAL: Failed assertion: !mismatch
(kms_plane_lowres:1482) igt-debugfs-CRITICAL: Last errno: 9, Bad file descriptor
Subtest pipe-C-tiling-y failed.
Comment 12 Marta Löfstedt 2018-01-09 14:29:07 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4126/shard-apl2/igt@kms_plane_multiple@atomic-pipe-b-tiling-none.html

(kms_plane_multiple:1449) igt-debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file igt_debugfs.c:356:
(kms_plane_multiple:1449) igt-debugfs-CRITICAL: Failed assertion: !mismatch
(kms_plane_multiple:1449) igt-debugfs-CRITICAL: Last errno: 25, Inappropriate ioctl for device
Subtest atomic-pipe-B-tiling-none failed.
Comment 13 Marta Löfstedt 2018-01-12 13:19:50 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4133/shard-apl8/igt@kms_plane_multiple@atomic-pipe-b-tiling-y.html

(kms_plane_multiple:1485) igt-debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file igt_debugfs.c:356:
(kms_plane_multiple:1485) igt-debugfs-CRITICAL: Failed assertion: !mismatch
(kms_plane_multiple:1485) igt-debugfs-CRITICAL: Last errno: 25, Inappropriate ioctl for device
Subtest atomic-pipe-B-tiling-y failed.
Comment 14 Marta Löfstedt 2018-01-15 07:15:02 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3628/shard-apl6/igt@kms_plane_lowres@pipe-b-tiling-yf.html

(kms_plane_lowres:1521) igt-debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file igt_debugfs.c:356:
(kms_plane_lowres:1521) igt-debugfs-CRITICAL: Failed assertion: !mismatch
(kms_plane_lowres:1521) igt-debugfs-CRITICAL: Last errno: 9, Bad file descriptor
Subtest pipe-B-tiling-yf failed.
Comment 15 Marta Löfstedt 2018-01-24 07:12:56 UTC
Now also seen on HSW-shards:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3674/shard-hsw8/igt@kms_plane_multiple@legacy-pipe-a-tiling-none.html

(kms_plane_multiple:5031) igt-debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file igt_debugfs.c:356:
(kms_plane_multiple:5031) igt-debugfs-CRITICAL: Failed assertion: !mismatch
(kms_plane_multiple:5031) igt-debugfs-CRITICAL: Last errno: 25, Inappropriate ioctl for device
Subtest legacy-pipe-A-tiling-none failed.
Comment 16 Marta Löfstedt 2018-02-01 07:09:21 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3708/shard-apl2/igt@kms_plane_multiple@atomic-pipe-b-tiling-yf.html

(kms_plane_multiple:1474) igt-debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file igt_debugfs.c:356:
(kms_plane_multiple:1474) igt-debugfs-CRITICAL: Failed assertion: !mismatch
(kms_plane_multiple:1474) igt-debugfs-CRITICAL: Last errno: 25, Inappropriate ioctl for device
Subtest atomic-pipe-B-tiling-yf failed.
Comment 17 Marta Löfstedt 2018-02-02 07:24:10 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3712/shard-apl1/igt@kms_plane@plane-position-hole-dpms-pipe-a-planes.html

(kms_plane:1447) igt-debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file igt_debugfs.c:356:
(kms_plane:1447) igt-debugfs-CRITICAL: Failed assertion: !mismatch
Subtest plane-position-hole-dpms-pipe-A-planes failed.
Comment 18 Marta Löfstedt 2018-02-12 08:31:46 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4240/shard-apl2/igt@kms_plane@plane-panning-top-left-pipe-b-planes.html

(kms_plane:1443) igt-debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file igt_debugfs.c:356:
(kms_plane:1443) igt-debugfs-CRITICAL: Failed assertion: !mismatch
Subtest plane-panning-top-left-pipe-B-planes failed.
Comment 19 Marta Löfstedt 2018-02-14 07:45:18 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3763/shard-apl5/igt@kms_plane_lowres@pipe-a-tiling-x.html

(kms_plane_lowres:1511) igt-debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file igt_debugfs.c:356:
(kms_plane_lowres:1511) igt-debugfs-CRITICAL: Failed assertion: !mismatch
(kms_plane_lowres:1511) igt-debugfs-CRITICAL: Last errno: 9, Bad file descriptor
Subtest pipe-A-tiling-x failed.
Comment 20 Marta Löfstedt 2018-02-15 06:58:47 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3773/shard-apl3/igt@kms_plane_lowres@pipe-a-tiling-yf.html

(kms_plane_lowres:2924) igt-debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file igt_debugfs.c:356:
(kms_plane_lowres:2924) igt-debugfs-CRITICAL: Failed assertion: !mismatch
(kms_plane_lowres:2924) igt-debugfs-CRITICAL: Last errno: 9, Bad file descriptor
Subtest pipe-A-tiling-yf failed.
Comment 21 Marta Löfstedt 2018-02-20 12:43:08 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4271/shard-apl5/igt@kms_plane_multiple@atomic-pipe-c-tiling-y.html


(kms_plane_multiple:2144) igt-debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file igt_debugfs.c:370:
(kms_plane_multiple:2144) igt-debugfs-CRITICAL: Failed assertion: !mismatch
(kms_plane_multiple:2144) igt-debugfs-CRITICAL: Last errno: 25, Inappropriate ioctl for device
Subtest atomic-pipe-C-tiling-y failed.
Comment 22 Mika Kahola 2018-02-23 12:56:43 UTC
For kms_plane_multiple

https://patchwork.freedesktop.org/series/38851/
Comment 23 Marta Löfstedt 2018-02-26 07:21:51 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3830/shard-apl2/igt@kms_plane@plane-position-hole-dpms-pipe-b-planes.html

(kms_plane:1682) igt-debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file igt_debugfs.c:370:
(kms_plane:1682) igt-debugfs-CRITICAL: Failed assertion: !mismatch
Subtest plane-position-hole-dpms-pipe-B-planes failed.
Comment 24 Jani Saarinen 2018-02-26 12:00:23 UTC
New reference: https://patchwork.freedesktop.org/series/38945/
Comment 25 Marta Löfstedt 2018-03-06 07:00:27 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4328/shard-apl5/igt@kms_plane_multiple@legacy-pipe-c-tiling-x.html

(kms_plane_multiple:1606) igt-debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file igt_debugfs.c:370:
(kms_plane_multiple:1606) igt-debugfs-CRITICAL: Failed assertion: !mismatch
(kms_plane_multiple:1606) igt-debugfs-CRITICAL: Last errno: 25, Inappropriate ioctl for device
Subtest legacy-pipe-C-tiling-x failed.
Comment 26 Mika Kahola 2018-03-06 13:42:26 UTC
(In reply to Marta Löfstedt from comment #25)
> https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4328/shard-apl5/
> igt@kms_plane_multiple@legacy-pipe-c-tiling-x.html
> 
> (kms_plane_multiple:1606) igt-debugfs-CRITICAL: Test assertion failure
> function igt_assert_crc_equal, file igt_debugfs.c:370:
> (kms_plane_multiple:1606) igt-debugfs-CRITICAL: Failed assertion: !mismatch
> (kms_plane_multiple:1606) igt-debugfs-CRITICAL: Last errno: 25,
> Inappropriate ioctl for device
> Subtest legacy-pipe-C-tiling-x failed.

For this there is a patch waiting for a review

https://patchwork.freedesktop.org/series/38851/
Comment 27 Marta Löfstedt 2018-03-13 07:03:43 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4346/shard-apl5/igt@kms_plane@plane-position-hole-pipe-b-planes.html

(kms_plane:2660) igt_debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file ../lib/igt_debugfs.c:370:
(kms_plane:2660) igt_debugfs-CRITICAL: Failed assertion: !mismatch
Subtest plane-position-hole-pipe-B-planes failed.
Comment 28 Marta Löfstedt 2018-03-13 14:21:28 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4353/shard-snb6/igt@kms_plane_multiple@atomic-pipe-a-tiling-x.html

(kms_plane_multiple:1493) igt_debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file ../lib/igt_debugfs.c:370:
(kms_plane_multiple:1493) igt_debugfs-CRITICAL: Failed assertion: !mismatch
(kms_plane_multiple:1493) igt_debugfs-CRITICAL: Last errno: 11, Resource temporarily unavailable
Subtest atomic-pipe-A-tiling-x failed.
Comment 29 Marta Löfstedt 2018-03-16 09:01:44 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-skl-6600u/igt@kms_plane_multiple@atomic-pipe-a-tiling-x.html

(kms_plane_multiple:1865) igt_debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file ../lib/igt_debugfs.c:370:
(kms_plane_multiple:1865) igt_debugfs-CRITICAL: Failed assertion: !mismatch
(kms_plane_multiple:1865) igt_debugfs-CRITICAL: Last errno: 11, Resource temporarily unavailable
Subtest atomic-pipe-A-tiling-x failed.
Comment 30 Marta Löfstedt 2018-03-16 09:02:44 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-skl-6700k2/igt@kms_plane@plane-position-hole-dpms-pipe-b-planes.html
	
(kms_plane:2907) igt_debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file ../lib/igt_debugfs.c:370:
(kms_plane:2907) igt_debugfs-CRITICAL: Failed assertion: !mismatch
Subtest plane-position-hole-dpms-pipe-B-planes failed.
Comment 31 Marta Löfstedt 2018-03-19 14:44:40 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_4/fi-bxt-dsi/igt@kms_plane@plane-position-covered-pipe-a-planes.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_4/fi-cfl-8700k/igt@kms_plane@plane-position-covered-pipe-a-planes.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_4/fi-skl-6600u/igt@kms_plane@plane-position-covered-pipe-a-planes.html

(kms_plane:1415) igt_debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file ../lib/igt_debugfs.c:370:
(kms_plane:1415) igt_debugfs-CRITICAL: Failed assertion: !mismatch
Subtest plane-position-covered-pipe-A-planes failed.
Comment 32 Martin Peres 2018-03-20 08:19:35 UTC
Also seen on KBL: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3950/shard-kbl1/igt@kms_plane@plane-position-covered-pipe-a-planes.html

(kms_plane:1530) igt_debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file ../lib/igt_debugfs.c:370:
(kms_plane:1530) igt_debugfs-CRITICAL: Failed assertion: !mismatch
Subtest plane-position-covered-pipe-A-planes failed.
Comment 34 Marta Löfstedt 2018-03-26 13:07:57 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_7/fi-ilk-m540/igt@kms_plane_multiple@atomic-pipe-a-tiling-x.html

(kms_plane_multiple:1452) igt_debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file ../lib/igt_debugfs.c:370:
(kms_plane_multiple:1452) igt_debugfs-CRITICAL: Failed assertion: !mismatch
(kms_plane_multiple:1452) igt_debugfs-CRITICAL: Last errno: 11, Resource temporarily unavailable
Subtest atomic-pipe-A-tiling-x failed.
Comment 35 Mika Kahola 2018-04-18 08:52:49 UTC
I sent a patch

https://patchwork.freedesktop.org/series/41877/

that fixes one anomality. Let's wait for CI runs and see if it would fix the !mismatch error as well.
Comment 36 Lakshmi 2018-09-04 10:15:51 UTC
Mika, looks like the patch didn't fix the mismatch error. This issue occurs with every drm-tip run and frequently with CI DRM Full run as well.
Comment 38 Mika Kahola 2018-11-29 06:52:40 UTC
One idea to tackle crc mismatches.

As we see fifo underruns on tests that fail with crc mismatch we could detect those fifo underruns and skip a crc as we already do when reading crc for the first time.
Comment 39 Daniel Vetter 2019-03-11 09:55:52 UTC
We need to close this one, this bug has become a mess:

- no more fifo underruns it seems

At least 2 new bugs:

1. for igt@kms_plane@pixel-format-pipe-a-planes (also b/c ofc) on icl-u3:

Crash signature is:

Testing format NV12 (0x3231564e) on A.2
Stack trace:
  #0 ../lib/igt_core.c:1474 __igt_fail_assert()
  #1 ../lib/igt_debugfs.c:420 igt_assert_crc_equal()
  #2 ../tests/kms_plane.c:550 test_format_plane()
  #3 ../tests/kms_plane.c:582 test_pixel_formats()
  #4 ../tests/kms_plane.c:597 run_tests_for_pipe_plane()
  #5 ../tests/kms_plane.c:652 __real_main637()
  #6 ../tests/kms_plane.c:637 main()
  #7 ../csu/libc-start.c:344 __libc_start_main()
  #8 [_start+0x2a]
Subtest pixel-format-pipe-A-planes: FAIL (547.114s)
Test requirement not met in function run_tests_for_pipe_plane, file ../tests/kms_plane.c:593:
Test requirement: !(pipe >= data->display.n_pipes)

A.2 can also be B.2 for b-planes and C.2 for c-planes


2. bug: igt@kms_plane_multiple@atomic * on icl-u3: No idea yet what's going on there.

3. All the other platforms: Not sure it's a good idea to smash them all into one place. We need to at least separate the bugs where we also have a fifo underrun from crc mistmatches for other reasons. Since my igt patch

commit 4d0d81a2176227a7432762ae095ba386f3c8aba0
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Tue Feb 19 10:11:06 2019 +0100

    lib/crc: Reset fifo underrun reporting for every crc capture

we should be able to tell these two cases apart with 100% accuracy.
Comment 40 Daniel Vetter 2019-03-11 10:08:39 UTC
I think it would also make sense to split kms_plane bugs from kms_plane_multiple. They're testing quite different things really. Maybe only for cases where we do _not_ have fifo underruns.
Comment 41 CI Bug Log 2019-03-13 14:53:15 UTC
A CI Bug Log filter associated to this bug has been updated:

{- all machine: igt@kms_plane-*@* - Failed CRC mismatch -}
{+ all machine: igt@kms_plane-*@* - Failed CRC mismatch +}

 No new failures caught with the new filter
Comment 42 Martin Peres 2019-03-13 15:17:39 UTC
(In reply to Daniel Vetter from comment #39)
> We need to close this one, this bug has become a mess:

It has always been, but yeah, it is high time we do something about this bug!

> 
> - no more fifo underruns it seems

\o/

> 
> At least 2 new bugs:
> 
> 1. for igt@kms_plane@pixel-format-pipe-a-planes (also b/c ofc) on icl-u3:
> 
> Crash signature is:
> 
> Testing format NV12 (0x3231564e) on A.2
> Stack trace:
>   #0 ../lib/igt_core.c:1474 __igt_fail_assert()
>   #1 ../lib/igt_debugfs.c:420 igt_assert_crc_equal()
>   #2 ../tests/kms_plane.c:550 test_format_plane()
>   #3 ../tests/kms_plane.c:582 test_pixel_formats()
>   #4 ../tests/kms_plane.c:597 run_tests_for_pipe_plane()
>   #5 ../tests/kms_plane.c:652 __real_main637()
>   #6 ../tests/kms_plane.c:637 main()
>   #7 ../csu/libc-start.c:344 __libc_start_main()
>   #8 [_start+0x2a]
> Subtest pixel-format-pipe-A-planes: FAIL (547.114s)
> Test requirement not met in function run_tests_for_pipe_plane, file
> ../tests/kms_plane.c:593:
> Test requirement: !(pipe >= data->display.n_pipes)
> 
> A.2 can also be B.2 for b-planes and C.2 for c-planes

The test got reworked, and kms_plane issues on ICL are now tracked in: https://bugs.freedesktop.org/show_bug.cgi?id=110032

APL issues got moved to https://bugs.freedesktop.org/show_bug.cgi?id=110033

The others will get a per-platform bug as they pop up :)

(In reply to Daniel Vetter from comment #39)
> 2. bug: igt@kms_plane_multiple@atomic * on icl-u3: No idea yet what's going
> on there.

The issue has been split into this bug: https://bugs.freedesktop.org/show_bug.cgi?id=110037

> 
> 3. All the other platforms: Not sure it's a good idea to smash them all into
> one place. We need to at least separate the bugs where we also have a fifo
> underrun from crc mistmatches for other reasons. Since my igt patch
> 
> commit 4d0d81a2176227a7432762ae095ba386f3c8aba0
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date:   Tue Feb 19 10:11:06 2019 +0100
> 
>     lib/crc: Reset fifo underrun reporting for every crc capture
> 
> we should be able to tell these two cases apart with 100% accuracy.

Agreed... but not too sure how to proceed on this. I should create a view that would allow me to mass-suppress tests in order to deal with this sort of issues...

I also split the igt@kms_plane@plane-position-covered-pipe-[abc]-planes failures to https://bugs.freedesktop.org/show_bug.cgi?id=110038

I will suppress some of the tests and remove them from the filter.
Comment 43 CI Bug Log 2019-03-13 15:18:50 UTC
A CI Bug Log filter associated to this bug has been updated:

{- all machine: igt@kms_plane-*@* - Failed CRC mismatch -}
{+ all machine: igt@kms_plane-*@* - Failed CRC mismatch +}

 No new failures caught with the new filter
Comment 44 CI Bug Log 2019-03-13 15:25:06 UTC
A CI Bug Log filter associated to this bug has been updated:

{- all machine: igt@kms_plane-*@* - Failed CRC mismatch -}
{+ all machine: igt@kms_plane-*@* - Failed CRC mismatch +}

 No new failures caught with the new filter
Comment 45 CI Bug Log 2019-03-14 13:31:38 UTC
A CI Bug Log filter associated to this bug has been updated:

{- all machine: igt@kms_plane-*@* - Failed CRC mismatch -}
{+ all machine: igt@kms_plane-*@* - Failed CRC mismatch +}

 No new failures caught with the new filter
Comment 46 Lakshmi 2019-03-15 13:09:20 UTC
This bug is split in to many bugs are as mentioned in comment 42. Closing this bug.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.