| Summary: | broadcom/vc5: double compare | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Grazvydas Ignotas <notasas> |
| Component: | Drivers/DRI/v3d | Assignee: | Eric Anholt <eric> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | dcb314 |
| Version: | git | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
also in src/gallium/drivers/vc5/vc5_emit.c:
+ int min_img_filter = psampler->min_img_filter;
+ int min_mip_filter = psampler->min_mip_filter;
+ int mag_img_filter = psampler->mag_img_filter;
+
+ if (vc5_get_tex_return_size(psview->format) == 32) {
+ min_mip_filter = PIPE_TEX_MIPFILTER_NEAREST;
+ mag_img_filter = PIPE_TEX_FILTER_NEAREST;
+ mag_img_filter = PIPE_TEX_FILTER_NEAREST;
+ }
did you mean min_img_filter instead of setting mag_img_filter twice?
*** Bug 105783 has been marked as a duplicate of this bug. *** First one was already gone, second one fixed with: commit b2e7c32703fde3944b227927a0f8094da521ae39 (HEAD, origin/master, anholt/vc5-publish) Author: Eric Anholt <eric@anholt.net> Date: Tue May 1 17:22:09 2018 -0700 v3d: Fix wiring filters to NEAREST for 32-bit texture returns. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104626 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
2e3c7beb1e60a47e1f5dd12d28ac3f328555a543 adds: + if (surf->format == PIPE_FORMAT_B4G4R4A4_UNORM || + surf->format == PIPE_FORMAT_B4G4R4A4_UNORM) { perhaps something else was intended?