Bug 105783 - mesa-18.0.0/src/gallium/drivers/vc5/vc5_draw.c:589: duplicate expression ?
Summary: mesa-18.0.0/src/gallium/drivers/vc5/vc5_draw.c:589: duplicate expression ?
Status: RESOLVED DUPLICATE of bug 104626
Alias: None
Product: Mesa
Classification: Unclassified
Component: Other (show other bugs)
Version: 17.3
Hardware: Other All
: medium normal
Assignee: Eric Anholt
QA Contact: mesa-dev
Depends on:
Reported: 2018-03-28 11:18 UTC by dcb314
Modified: 2018-03-28 12:17 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Description dcb314 2018-03-28 11:18:58 UTC
[mesa-18.0.0/src/gallium/drivers/vc5/vc5_draw.c:589]: (style) Same expression on both sides of '||'.

Source code is

      if (surf->format == PIPE_FORMAT_B4G4R4A4_UNORM ||
          surf->format == PIPE_FORMAT_B4G4R4A4_UNORM) {

Suggest either simplify expression or use some other constant.
Comment 1 Eric Engestrom 2018-03-28 12:09:09 UTC
This was introduced in 2e3c7beb1e60a47e1f5dd "broadcom/vc5: Pack clear colors according to the TLB internal format/type."
Comment 2 Grazvydas Ignotas 2018-03-28 12:17:44 UTC

*** This bug has been marked as a duplicate of bug 104626 ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.