Bug 104626 - broadcom/vc5: double compare
Summary: broadcom/vc5: double compare
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/v3d (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Eric Anholt
QA Contact:
URL:
Whiteboard:
Keywords:
: 105783 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-01-14 19:49 UTC by Grazvydas Ignotas
Modified: 2018-05-16 21:26 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Grazvydas Ignotas 2018-01-14 19:49:57 UTC
2e3c7beb1e60a47e1f5dd12d28ac3f328555a543 adds:

+                        if (surf->format == PIPE_FORMAT_B4G4R4A4_UNORM ||
+                            surf->format == PIPE_FORMAT_B4G4R4A4_UNORM) {

perhaps something else was intended?
Comment 1 Grazvydas Ignotas 2018-01-14 21:29:49 UTC
also in src/gallium/drivers/vc5/vc5_emit.c:

+        int min_img_filter = psampler->min_img_filter;
+        int min_mip_filter = psampler->min_mip_filter;
+        int mag_img_filter = psampler->mag_img_filter;
+
+        if (vc5_get_tex_return_size(psview->format) == 32) {
+                min_mip_filter = PIPE_TEX_MIPFILTER_NEAREST;
+                mag_img_filter = PIPE_TEX_FILTER_NEAREST;
+                mag_img_filter = PIPE_TEX_FILTER_NEAREST;
+        }

did you mean min_img_filter instead of setting mag_img_filter twice?
Comment 2 Grazvydas Ignotas 2018-03-28 12:17:44 UTC
*** Bug 105783 has been marked as a duplicate of this bug. ***
Comment 3 Eric Anholt 2018-05-16 21:26:57 UTC
First one was already gone, second one fixed with:

commit b2e7c32703fde3944b227927a0f8094da521ae39 (HEAD, origin/master, anholt/vc5-publish)
Author: Eric Anholt <eric@anholt.net>
Date:   Tue May 1 17:22:09 2018 -0700

    v3d: Fix wiring filters to NEAREST for 32-bit texture returns.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104626


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.