Bug 104782

https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4293/shard-apl8/igt@kms_color@pipe-a-legacy-gamma.html

(kms_color:2005) igt-debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file igt_debugfs.c:370:
(kms_color:2005) igt-debugfs-CRITICAL: Failed assertion: !mismatch
Subtest pipe-A-legacy-gamma failed.

https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4338/shard-apl2/igt@kms_color@pipe-b-gamma.html

(kms_color:1717) igt-debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file igt_debugfs.c:370:
(kms_color:1717) igt-debugfs-CRITICAL: Failed assertion: !mismatch
Subtest pipe-B-gamma failed.

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_6/fi-cfl-8700k/igt@kms_color@pipe-a-legacy-gamma.html

(kms_color:1541) igt_debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file ../lib/igt_debugfs.c:370:
(kms_color:1541) igt_debugfs-CRITICAL: Failed assertion: !mismatch
Subtest pipe-A-legacy-gamma failed.

Last seen: None according to cibuglogger. Can we close it?

This issue was not seen last 6 months. This issue occurred only once few hundred's of runs ago. Closing this bug.

Guess who's back?

https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4666/shard-apl4/igt@kms_color@pipe-b-degamma.html

https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4671/shard-kbl2/igt@kms_color@pipe-c-legacy-gamma.html

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_4945/shard-kbl3/igt@kms_color@pipe-c-legacy-gamma.html

Starting subtest: pipe-C-legacy-gamma
(kms_color:2304) igt_debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file ../lib/igt_debugfs.c:392:
(kms_color:2304) igt_debugfs-CRITICAL: Failed assertion: !mismatch
Subtest pipe-C-legacy-gamma failed.

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_4945/shard-skl2/igt@kms_color@pipe-c-legacy-gamma.html

Starting subtest: pipe-C-legacy-gamma
(kms_color:2227) igt_debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file ../lib/igt_debugfs.c:392:
(kms_color:2227) igt_debugfs-CRITICAL: Failed assertion: !mismatch
Subtest pipe-C-legacy-gamma failed.

Also seen on WHL, CFL and BXT!

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_121/fi-whl-u/igt@kms_color@pipe-c-legacy-gamma.html

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_121/fi-cfl-s3/igt@kms_color@pipe-c-legacy-gamma.html

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_121/fi-cfl-guc/igt@kms_color@pipe-c-legacy-gamma.html

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_121/fi-cfl-8700k/igt@kms_color@pipe-c-legacy-gamma.html

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_121/fi-cfl-8109u/igt@kms_color@pipe-c-legacy-gamma.html

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_121/fi-bxt-j4205/igt@kms_color@pipe-c-legacy-gamma.html

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_121/fi-bxt-dsi/igt@kms_color@pipe-c-legacy-gamma.html

Starting subtest: pipe-C-legacy-gamma
(kms_color:2339) igt_debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file ../lib/igt_debugfs.c:392:
(kms_color:2339) igt_debugfs-CRITICAL: Failed assertion: !mismatch
Subtest pipe-C-legacy-gamma failed.

https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4677/shard-skl3/igt@kms_color@pipe-b-gamma.html

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_4981/shard-skl3/igt@kms_color@pipe-b-gamma.html

Starting subtest: pipe-B-gamma
(kms_color:2123) igt_debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file ../lib/igt_debugfs.c:392:
(kms_color:2123) igt_debugfs-CRITICAL: Failed assertion: !mismatch
Subtest pipe-B-gamma failed.

A CI Bug Log filter associated to this bug has been updated:

{- SKL BXT APL KBL CFL WHL: igt@kms_color@pipe-[abc]-*gamma* - Failed assertion: !mismatch -}
{+ SKL BXT APL KBL CFL WHL ICL: igt@kms_color@pipe-[abc]-*gamma* - Failed assertion: !mismatch +}

New failures caught by the filter:

* https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5598/shard-iclb1/igt@kms_color@pipe-a-degamma.html
* https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5598/shard-iclb1/igt@kms_color@pipe-a-gamma.html
* https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5598/shard-iclb7/igt@kms_color@pipe-c-legacy-gamma.html
* https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5598/shard-iclb7/igt@kms_color@pipe-a-legacy-gamma.html
* https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4824/shard-iclb3/igt@kms_color@pipe-b-legacy-gamma.html
* https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4824/shard-iclb6/igt@kms_color@pipe-a-legacy-gamma.html
* https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4824/shard-iclb7/igt@kms_color@pipe-a-degamma.html

A CI Bug Log filter associated to this bug has been updated:

{- SKL BXT APL KBL CFL WHL ICL: igt@kms_color@pipe-[abc]-*gamma* - Failed assertion: !mismatch -}
{+ SKL BXT APL KBL GLK CFL WHL ICL: igt@kms_color@pipe-[abc]-*gamma* - Failed assertion: !mismatch +}

New failures caught by the filter:

* https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5598/shard-glk1/igt@kms_color@pipe-c-legacy-gamma.html
* https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5598/shard-glk2/igt@kms_color@pipe-b-degamma.html
* https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5598/shard-glk3/igt@kms_color@pipe-c-degamma.html
* https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4824/shard-glk4/igt@kms_color@pipe-b-degamma.html
* https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4824/shard-glk8/igt@kms_color@pipe-c-degamma.html

Assigned to Uma

A CI Bug Log filter associated to this bug has been updated:

{- SKL BXT APL KBL GLK CFL WHL ICL: igt@kms_color@pipe-[abc]-*gamma* - Failed assertion: !mismatch -}
{+ BSW BXT APL SKL KBL GLK CFL WHL ICL: igt@kms_color@pipe-[abc]-*gamma* - Failed assertion: !mismatch +}

New failures caught by the filter:

* https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_225/fi-bsw-n3050/igt@kms_color@pipe-c-degamma.html

This issue is happening due to pipe rounding (an expected behaviour in such scenario, confirmed with hw architect Runyan, Art as well) causing crc to mismatch. Unfortunately the test relies on the crc.
But checked on simulation and dump the pipe bmp output and compared bit by bit with the expected output. The data was matching perfectly. There will no visible impact to user as the framebuffer content is perfect, so user will not be able to see any issues. 

Future actions planned is :
  -  Use pipe writeback to get the framebuffer and check the pixel values directly (need to implement it first)
  - Use chamelium as a workaround for the lack of pipe writeback

All this will need significant implementation on driver side and even the tests need to re-written to align this. We will work on it separately.

A CI Bug Log filter associated to this bug has been updated:

{- BSW BXT APL SKL KBL GLK CFL WHL ICL: igt@kms_color@pipe-[abc]-*gamma* - Failed assertion: !mismatch -}
{+ BYT BSW BXT APL SKL KBL GLK CFL WHL ICL: igt@kms_color@pipe-[abc]-*gamma* - Failed assertion: !mismatch +}

New failures caught by the filter:

* https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_249/fi-byt-clapper/igt@kms_color@pipe-a-legacy-gamma.html

Based on assessment lowering priority.

ICL fixed by

commit 09b25812db10fcbd7937c1b7ca279c5c0d77ba9d 
Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
Date:   Fri Apr 12 21:30:09 2019 +0300

    drm/i915: Enable pipe HDR mode on ICL if only HDR planes are used
    
I did forger to add the bugzilla link to the commit :/

(In reply to Ville Syrjala from comment #18)
> ICL fixed by
> 
> commit 09b25812db10fcbd7937c1b7ca279c5c0d77ba9d 
> Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Date:   Fri Apr 12 21:30:09 2019 +0300
> 
>     drm/i915: Enable pipe HDR mode on ICL if only HDR planes are used
>     
> I did forger to add the bugzilla link to the commit :/

https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5080/shard-iclb8/igt@kms_color@pipe-a-degamma.html
	
Starting subtest: pipe-A-degamma
(kms_color:5428) igt_debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file ../lib/igt_debugfs.c:419:
(kms_color:5428) igt_debugfs-CRITICAL: Failed assertion: !mismatch
Subtest pipe-A-degamma failed.

https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5081/shard-iclb7/igt@kms_color@pipe-c-degamma.html

Still occurring on ICL, does these failures need a separate bug?

A CI Bug Log filter associated to this bug has been updated:

{- BYT BSW BXT APL SKL KBL GLK CFL WHL ICL: igt@kms_color@pipe-[abc]-*gamma* - Failed assertion: !mismatch -}
{+ BYT BSW BXT APL SKL KBL GLK CFL WHL CML ICL: igt@kms_color@pipe-[abc]-*gamma* - Failed assertion: !mismatch +}

New failures caught by the filter:

  * https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_320/fi-cml-u/igt@kms_color@pipe-b-degamma.html
  * https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_320/fi-cml-u2/igt@kms_color@pipe-b-degamma.html

kms_color test performs checks for color to match and gamma features on pipe level.

Failing each one of the test yields poor color presentation on display and degraded user experience.

#assessment

This is happening on ICL+ due to multi segmented gamma being enabled. Reason is due to pipe roundup and interpolation, the crc values goes off and doesn't match exactly. This results in the tests to fail, however this is expected and no visual artifacts are observed. 

This matched in 10 bit gamma cases, because the precision was slightly low and hence 2 input values which though not equal got same result after LUT lookup due to interpolation (slightly different inputs yielded same value on lookup). However with multi segmented gamma, we have more precision and higher number of samples. The exact same input values got mapped to different values on LUT lookup. This caused crc's to mismatch.

There is no functional issue, and we may have to re-design the test methodology to avoid relying on crc matches for these tests.

*** Bug 111702 has been marked as a duplicate of this bug. ***

Adding TGL platform too.

A CI Bug Log filter associated to this bug has been updated:

{- BYT BSW BXT APL SKL KBL GLK CFL WHL CML ICL: igt@kms_color@pipe-[abc]-*gamma* - Failed assertion: !mismatch -}
{+ BYT BSW BXT APL SKL KBL GLK CFL WHL CML ICL TGL: igt@kms_color@pipe-[abc]-*gamma* - Failed assertion: !mismatch +}


  No new failures caught with the new filter

The CI Bug Log issue associated to this bug has been updated.

### New filters associated

* TGL: igt@kms_color@pipe-[abc]-degamma - fail - Failed assertion: !mismatch || igt_skip_crc_compare
  (No new failures associated)

A CI Bug Log filter associated to this bug has been updated:

{- TGL: igt@kms_color@pipe-[abc]-degamma - fail - Failed assertion: !mismatch || igt_skip_crc_compare -}
{+ TGL: igt@kms_color@pipe-[abc]-degamma - fail - Failed assertion: !mismatch || igt_skip_crc_compare +}

New failures caught by the filter:

  * https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5226/shard-tglb1/igt@kms_color@pipe-d-degamma.html
  * https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5230/shard-tglb5/igt@kms_color@pipe-d-degamma.html

A CI Bug Log filter associated to this bug has been updated:

{- BYT BSW BXT APL SKL KBL GLK CFL WHL CML ICL TGL: igt@kms_color@pipe-[abc]-*gamma* - Failed assertion: !mismatch -}
{+ BYT BSW BXT APL SKL KBL GLK CFL WHL CML ICL: igt@kms_color@pipe-[abc]-*gamma* - Failed assertion: !mismatch +}


  No new failures caught with the new filter

A CI Bug Log filter associated to this bug has been updated:

{- TGL: igt@kms_color@pipe-[abc]-degamma - fail - Failed assertion: !mismatch || igt_skip_crc_compare -}
{+ TGL: igt@kms_color@pipe-[abc]-degamma - fail - Failed assertion: !mismatch || igt_skip_crc_compare +}

New failures caught by the filter:

  * https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5260/shard-tglb7/igt@kms_color@pipe-a-gamma.html

A CI Bug Log filter associated to this bug has been updated:

{- TGL: igt@kms_color@pipe-[abc]-degamma - fail - Failed assertion: !mismatch || igt_skip_crc_compare -}
{+ TGL: igt@kms_color@pipe-[abcd]-(gamma|degamma) - fail - Failed assertion: !mismatch || igt_skip_crc_compare +}


  No new failures caught with the new filter

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/drm/intel/issues/71.