Bug 109355

Summary: [CI][SHARDS] igt@kms_frontbuffer_tracking@*psr* - fail - Failed assertion: psr_wait_entry(drm.debugfs), PSR still disabled
Product: DRI Reporter: Martin Peres <martin.peres>
Component: DRM/IntelAssignee: Intel GFX Bugs mailing list <intel-gfx-bugs>
Status: CLOSED DUPLICATE QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: normal    
Priority: high CC: intel-gfx-bugs, jose.souza
Version: XOrg git   
Hardware: Other   
OS: All   
Whiteboard: ReadyForDev
i915 platform: ICL i915 features: display/PSR

Description Martin Peres 2019-01-14 16:37:23 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5414/shard-iclb7/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-gtt.html

(kms_frontbuffer_tracking:2720) CRITICAL: Test assertion failure function do_status_assertions, file ../tests/kms_frontbuffer_tracking.c:1637:
(kms_frontbuffer_tracking:2720) CRITICAL: Failed assertion: psr_wait_entry(drm.debugfs)
(kms_frontbuffer_tracking:2720) CRITICAL: PSR still disabled
Comment 1 Martin Peres 2019-01-14 16:38:31 UTC
This is quite likely related to https://bugs.freedesktop.org/show_bug.cgi?id=108733.
Comment 2 CI Bug Log 2019-01-14 16:38:54 UTC
The CI Bug Log issue associated to this bug has been updated.

### New filters associated

* ICL: igt@kms_frontbuffer_tracking@*psr* - fail - Failed assertion: psr_wait_entry(drm.debugfs), PSR still disabled
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5414/shard-iclb7/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-gtt.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5414/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap-gtt.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5414/shard-iclb7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-wc.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5414/shard-iclb7/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5414/shard-iclb7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-cpu.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5414/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-wc.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5414/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-render.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5414/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-render.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5414/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-cpu.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5414/shard-iclb7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5414/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-shrfb-fliptrack.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5414/shard-iclb7/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-blt.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5414/shard-iclb7/igt@kms_frontbuffer_tracking@psr-suspend.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5414/shard-iclb7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-pwrite.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5414/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt.html
Comment 3 Jose Roberto de Souza 2019-01-14 18:25:22 UTC
Yep another panel with a not reliable PSR implementation.
Our options are swap the panel or add PSR tests running into ICLB7 to the CI whitelist.
Comment 4 Martin Peres 2019-01-14 18:32:12 UTC
(In reply to Jose Roberto de Souza from comment #3)
> Yep another panel with a not reliable PSR implementation.
> Our options are swap the panel or add PSR tests running into ICLB7 to the CI
> whitelist.

I wonder how common these panels are in practice. I don't really care if this is just bad panels we use for testing, but if user machines tend to have these non-working panels, we should maybe try a little harder or find workarounds.

I'll add this panel to list of non-functioning panels.
Comment 5 Jose Roberto de Souza 2019-01-14 18:38:56 UTC
We plan in go back to those bad panels after a couple of kernel releases with PSR enabled by default.
Comment 6 Martin Peres 2019-01-14 21:38:44 UTC
(In reply to Jose Roberto de Souza from comment #5)
> We plan in go back to those bad panels after a couple of kernel releases
> with PSR enabled by default.

Sounds good :)
Comment 7 Martin Peres 2019-01-16 11:06:23 UTC
Funnily-enough, this panel is the only one that is supporting DSC.

Anyway, moving to to 109247, as recommended by José.

*** This bug has been marked as a duplicate of bug 109247 ***
Comment 8 CI Bug Log 2019-01-24 13:35:47 UTC
A CI Bug Log filter associated to this bug has been updated:

{- ICL: igt@kms_frontbuffer_tracking@*psr* - fail - Failed assertion: psr_wait_entry(drm.debugfs), PSR still disabled -}
{+ ICL: igt@kms_frontbuffer_tracking@*psr* - fail - Failed assertion: psr_wait_entry(drm.debugfs, PSR_MODE_1), PSR still disabled +}

New failures caught by the filter:

* https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5471/shard-iclb7/igt@kms_frontbuffer_tracking@psr-1p-pri-indfb-multidraw.html
* https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5471/shard-iclb7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-pgflip-blt.html
* https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5471/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc.html

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.