| Summary: | Xvfb fails XDrawText and XDrawText16 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Kevin E. Martin <kem> | ||||||
| Component: | Server/DDX/Xvfb | Assignee: | Roland Mainz <roland.mainz> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | high | CC: | eich, mat, roland.mainz, sndirsch | ||||||
| Version: | git | ||||||||
| Hardware: | x86 (IA32) | ||||||||
| OS: | Linux (All) | ||||||||
| Whiteboard: | |||||||||
| i915 platform: | i915 features: | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 1690 | ||||||||
| Attachments: |
|
||||||||
|
Description
Kevin E. Martin
2004-08-27 07:45:03 UTC
A couple of notes: 1. This has been verified on Red Hat and Debian. 2. These failures are relatively recent. Older server pass these tests. 3. I have verified that the changes that Keith Packard made to Xvfb have no effect on these tests (they fail with or without those changes). 4. The Xorg server using either the Radeon driver or the dummy driver pass these tests. Does someone has a screenshot (e.g. xwd dump, converted to GIF or PNG (not JPEG, please)) what exactly is going wrong ? The problem is with the Xvfb server while running the X test suite. To reproduce, you have to run the X test suite with these tests. There is a tool called "blowup" that allows you to see the pixel differences. See the X test suite documentation for how to run and use these tools. On today's release wranglers call, we decided to set a deadline for patches of today at 6pm EDT. If patches are available by then, are small and self-contained, they can still be integreated into the release. Otherwise, we will move the remaining open bugs to the release notes bug 999 for documentation. Created attachment 1319 [details] [review] damagetext.patch Patch, which fixes these failures (Hong Bo Peng <penghb@cn.ibm.com>). Anyone, who can commit this patch into CVS head? Stefan Dirsch wrote:
> Anyone, who can commit this patch into CVS head?
I can do that...
----
Taking bug for commit...
Created attachment 1360 [details] [review] [FIXED_X11R68x] Patch for commit to 2004-11-23-trunk Patch checked-in... /cvs/xorg/xc/ChangeLog,v <-- ChangeLog new revision: 1.538; previous revision: 1.537 /cvs/xorg/xc/programs/Xserver/miext/damage/damage.c,v <-- damage.c new revision: 1.12; previous revision: 1.11 Mailing the commit message to xorg-commit@pdx.freedesktop.org... ... marking bug as FIXED. Comment on attachment 1360 [details] [review] [FIXED_X11R68x] Patch for commit to 2004-11-23-trunk Requesting approval for commit to hje X11R6.8.x-branch. The patch is a trivial fix (function return value was lost in the damage extension layer and not forwarded to the caller) which solves X11 test suite failure. Comment on attachment 1360 [details] [review] [FIXED_X11R68x] Patch for commit to 2004-11-23-trunk Approved in the 2004-12-06 release-wranglers conference call. Please do not commit it yourself, I'll do that later today... Comment on attachment 1360 [details] [review] [FIXED_X11R68x] Patch for commit to 2004-11-23-trunk Patch checked-in into X11R6.8.x stable branch: /cvs/xorg/xc/ChangeLog,v <-- ChangeLog new revision: 1.365.2.18; previous revision: 1.365.2.17 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. /cvs/xorg/xc/programs/Xserver/miext/damage/damage.c,v <-- damage.c new revision: 1.11.2.1; previous revision: 1.11 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. Mailing the commit message to xorg-commit@lists.freedesktop.org... |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.