Bug 1204 - Xvfb fails XDrawText and XDrawText16
Summary: Xvfb fails XDrawText and XDrawText16
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/DDX/Xvfb (show other bugs)
Version: git
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Roland Mainz
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 1690
  Show dependency treegraph
 
Reported: 2004-08-27 07:45 UTC by Kevin E. Martin
Modified: 2004-12-11 21:57 UTC (History)
4 users (show)

See Also:
i915 platform:
i915 features:


Attachments
damagetext.patch (1.05 KB, patch)
2004-11-21 04:47 UTC, Stefan Dirsch
no flags Details | Splinter Review
[FIXED_X11R68x] Patch for commit to 2004-11-23-trunk (3.72 KB, patch)
2004-11-23 09:08 UTC, Roland Mainz
roland.mainz: 6.8-branch+
Details | Splinter Review

Description Kevin E. Martin 2004-08-27 07:45:03 UTC
The Xvfb server fails the following XDrawText* tests at all bit depths:

Tests for XDrawText: Test   1:  FAIL
Tests for XDrawText: Test   3:  FAIL
Tests for XDrawText: Test   4:  FAIL
Tests for XDrawText: Test  27:  FAIL
Tests for XDrawText: Test  28:  FAIL
Tests for XDrawText: Test  29:  FAIL
Tests for XDrawText: Test  30:  FAIL
Tests for XDrawText: Test  34:  FAIL
Tests for XDrawText: Test  37:  FAIL
Tests for XDrawText: Test  39:  FAIL
Tests for XDrawText: Test  41:  FAIL
Tests for XDrawText: Test  43:  FAIL
Tests for XDrawText16: Test   1:  FAIL
Tests for XDrawText16: Test   3:  FAIL
Tests for XDrawText16: Test   9:  FAIL
Tests for XDrawText16: Test  10:  FAIL
Tests for XDrawText16: Test  11:  FAIL
Tests for XDrawText16: Test  12:  FAIL
Tests for XDrawText16: Test  13:  FAIL
Tests for XDrawText16: Test  15:  FAIL
Tests for XDrawText16: Test  16:  FAIL
Tests for XDrawText16: Test  17:  FAIL
Tests for XDrawText16: Test  18:  FAIL
Tests for XDrawText16: Test  19:  FAIL
Tests for XDrawText16: Test  20:  FAIL
Tests for XDrawText16: Test  21:  FAIL
Tests for XDrawText16: Test  22:  FAIL
Tests for XDrawText16: Test  23:  FAIL
Tests for XDrawText16: Test  24:  FAIL
Tests for XDrawText16: Test  25:  FAIL
Tests for XDrawText16: Test  26:  FAIL
Tests for XDrawText16: Test  27:  FAIL
Tests for XDrawText16: Test  28:  FAIL
Tests for XDrawText16: Test  29:  FAIL
Tests for XDrawText16: Test  30:  FAIL
Tests for XDrawText16: Test  34:  FAIL
Tests for XDrawText16: Test  37:  FAIL
Tests for XDrawText16: Test  39:  FAIL
Tests for XDrawText16: Test  41:  FAIL
Tests for XDrawText16: Test  43:  FAIL
Comment 1 Kevin E. Martin 2004-08-27 07:49:40 UTC
A couple of notes:

1. This has been verified on Red Hat and Debian.
2. These failures are relatively recent.  Older server pass these tests.
3. I have verified that the changes that Keith Packard made to Xvfb have
   no effect on these tests (they fail with or without those changes).
4. The Xorg server using either the Radeon driver or the dummy driver pass
   these tests.
Comment 2 Roland Mainz 2004-08-31 09:25:10 UTC
Does someone has a screenshot (e.g. xwd dump, converted to GIF or PNG (not JPEG,
please)) what exactly is going wrong ?
Comment 3 Kevin E. Martin 2004-08-31 18:07:01 UTC
The problem is with the Xvfb server while running the X test suite.  To
reproduce, you have to run the X test suite with these tests.  There is a tool
called "blowup" that allows you to see the pixel differences.  See the X test
suite documentation for how to run and use these tools.
Comment 4 Kevin E. Martin 2004-09-01 10:30:35 UTC
On today's release wranglers call, we decided to set a deadline for patches of
today at 6pm EDT.  If patches are available by then, are small and
self-contained, they can still be integreated into the release.  Otherwise, we
will move the remaining open bugs to the release notes bug 999 for documentation.
Comment 5 Kevin E. Martin 2004-09-01 18:31:18 UTC
Moving to release notes bug 999 as noted earlier.
Comment 6 Stefan Dirsch 2004-11-21 04:47:18 UTC
Created attachment 1319 [details] [review]
damagetext.patch

Patch, which fixes these failures (Hong Bo Peng <penghb@cn.ibm.com>).
Comment 7 Stefan Dirsch 2004-11-23 02:09:43 UTC
Anyone, who can commit this patch into CVS head? 
Comment 8 Roland Mainz 2004-11-23 08:52:34 UTC
Stefan Dirsch wrote:
> Anyone, who can commit this patch into CVS head? 

I can do that...

----

Taking bug for commit...
Comment 9 Roland Mainz 2004-11-23 09:08:28 UTC
Created attachment 1360 [details] [review]
[FIXED_X11R68x] Patch for commit to 2004-11-23-trunk
Comment 10 Roland Mainz 2004-11-23 09:11:46 UTC
Patch checked-in...

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.538; previous revision: 1.537
/cvs/xorg/xc/programs/Xserver/miext/damage/damage.c,v  <--  damage.c
new revision: 1.12; previous revision: 1.11
Mailing the commit message to xorg-commit@pdx.freedesktop.org...

... marking bug as FIXED.
Comment 11 Roland Mainz 2004-11-23 09:13:55 UTC
Comment on attachment 1360 [details] [review]
[FIXED_X11R68x] Patch for commit to 2004-11-23-trunk

Requesting approval for commit to hje X11R6.8.x-branch.

The patch is a trivial fix (function return value was lost in the damage
extension layer and not forwarded to the caller) which solves X11 test suite
failure.
Comment 12 Roland Mainz 2004-12-08 06:08:17 UTC
Comment on attachment 1360 [details] [review]
[FIXED_X11R68x] Patch for commit to 2004-11-23-trunk

Approved in the 2004-12-06 release-wranglers conference call.
Please do not commit it yourself, I'll do that later today...
Comment 13 Roland Mainz 2004-12-12 16:57:07 UTC
Comment on attachment 1360 [details] [review]
[FIXED_X11R68x] Patch for commit to 2004-11-23-trunk

Patch checked-in into X11R6.8.x stable branch:

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.365.2.18; previous revision: 1.365.2.17
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/programs/Xserver/miext/damage/damage.c,v  <--  damage.c
new revision: 1.11.2.1; previous revision: 1.11
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
Mailing the commit message to xorg-commit@lists.freedesktop.org...


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.