| Summary: | Support for new Clickpad series of hardware | ||
|---|---|---|---|
| Product: | xorg | Reporter: | Jesse Jaara <jesse.jaara> |
| Component: | Input/synaptics | Assignee: | Peter Hutterer <peter.hutterer> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | medium | CC: | AhmedKhattabShams, brian, freedesktop.org, jonathan, Nasenbaer, nsoranzo, rogutes, scottt.tw, zoinkaholic |
| Version: | git | Keywords: | patch |
| Hardware: | All | ||
| OS: | Linux (All) | ||
| See Also: |
https://bugzilla.kernel.org/show_bug.cgi?id=41252 https://bugzilla.novell.com/show_bug.cgi?id=698412 https://launchpad.net/bugs/861437 |
||
| Whiteboard: | 2011BRB_Reviewed | ||
| i915 platform: | i915 features: | ||
| Bug Depends on: | |||
| Bug Blocks: | 39055, 45396 | ||
| Attachments: | |||
|
Description
Jesse Jaara
2011-06-14 07:44:50 UTC
Created attachment 47960 [details] [review] Initial clickpad support with led and power swich support. Created attachment 47961 [details] [review] Kernel patch to add clickpad led support to psmouse. 2.6.38&2.6.39 tested Jesse Jaara: looks like the first 2 patches were written by Takashi Iwai, but you posted them without any attribution (and thus they appear to be written by you, which is not right). The first 2 patches and much more were reviewed by Peter Hutterer and others [1], but Takashi Iwai didn't follow up. [1] http://lists.x.org/archives/xorg-devel/2010-October/thread.html#13821 I have an HP ProBook 4530s. Its touchpad has normal hardware buttons, and has a LED-button in the top left. Everything except the LED works without any patches. The LED needs patches to the kernel and to xf86-input-synaptics. Takashi Iwai submitted the kernel patch [2] (3rd patch posted by Jesse Jaara), got it reviewed and sent fixes, but it was not merged (forgotten?). I tried [2] + LED patches from [3] and the LED-button worked nicely... [2] http://lkml.org/lkml/2010/4/22/35 [3] https://build.opensuse.org/package/files?package=xorg-x11-driver-input&project=openSUSE%3AFactory I haven't checked the patches shown here, however OpenSuSe had its own patches for Clickpad, that worked fine with kernel 2.6.37.6, but did not with newer 3.0.x kernels. I initially posted this bug to the kernel bugtracker at https://bugzilla.kernel.org/show_bug.cgi?id=41252 Most important comment is: Comment #4 From Dmitry Torokhov 2011-08-25 18:02:41 OK, it looks like clickpad support still hasn't made it into official xf86-input-synaptics driver and adding multifinger support to kernel driver broke SUSE's detection of clickpads (they detect clickpads by having BTN_LEFT capability only, and we started reporting BTN_TOOL_DOUBLETAP). They should switch to checking INPUT_PROP_BUTTONPAD. Could someone *please* take care about the implementation! I added the link to the equivalent SuSe bug. Still no updates concerning this bug? No fix? I don't understand, how this can be such a big deal, even though it has been fixed in OpenSuse almost a year ago. There not only the clickpad itself works brilliantly but also the on/off switch with the white LED... Please feel free to submit patches to the list. http://wiki.x.org/wiki/Development/Documentation/SubmittingPatches *** Bug 43394 has been marked as a duplicate of this bug. *** Is there any hope for a better clickpad performance in coming versions due to the enormous advances in Xorg multitouch support pushed greatly by Peter Hutterer during the last few months? I saw all those articles on his blog (who-t..) and wondered if this will affect clickpad support in the near future. What do you think? (In reply to comment #9) > Is there any hope for a better clickpad performance in coming versions due to the enormous advances in Xorg multitouch support pushed greatly by Peter Hutterer > during the last few months? > > I saw all those articles on his blog (who-t..) and wondered if this will affect clickpad support in the near future. What do you think? http://lists.x.org/archives/xorg-devel/2012-February/029132.html commit 6c457c0c61a0834361f45a073148db7b4c9be40b Merge: defc1d0 fee18d8 Author: Peter Hutterer <peter.hutterer@who-t.net> Date: Wed Mar 14 08:48:00 2012 +1000 Merge branch 'clickpad-v3' *** Bug 40118 has been marked as a duplicate of this bug. *** *** Bug 22505 has been marked as a duplicate of this bug. *** |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.