Bug 44359

Summary:	On desktops without xterm, xdg-terminal's fallback for TERM="" simply fails
Product:	Portland	Reporter:	Stephan Sokolow <freedesktop.zen.ssokolow>
Component:	xdg-utils	Assignee:	Portland Bugs <portland-bugs>
Status:	RESOLVED MOVED	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Patch for more robust fallback behaviour (apply after patches for bugs 44357 and 44358) Rebased patch for more robust fallback behaviour

Description Stephan Sokolow 2011-12-31 17:45:37 UTC

Created attachment 55013 [details] [review]
Patch for more robust fallback behaviour (apply after patches for bugs 44357 and 44358)

Some distros (eg. Lubuntu) don't install xterm by default. Furthermore, some users may prefer urxvt (rxvt-unicode) to xterm.

The current git HEAD (b961235b197647d6649ef3d48d7cc2cecafe3d47) for xdg-terminal.in simply fails under these circumstances.

I'm not sure what the best solution would be in this case but, for my tool which needed a working xdg-terminal right now, I borrowed the colon-separated list $BROWSER code from xdg-open.

I'm attaching a patch in case it's of use. It depends on my patches for bug 44357 and bug 44358 but, if there's interest, I can rework it to apply against whatever you prefer.

The behaviour I chose was to prefer urxvt over rxvt and rxvt over xterm on the assumption that, while xterm is often installed by default, rxvt and rxvt-unicode being present generally indicates an explicit preference for them on the user's part.

Comment 1 Rex Dieter 2012-03-02 11:02:46 UTC

Thanks, I appied the previous fixes, but seems this one no longer applies.  Mind rebasing it?

Comment 2 Stephan Sokolow 2012-03-02 17:41:02 UTC

I ran out of free time before work today, but I'll try to rebase and submit a new patch either tonight or tomorrow.

Comment 3 Stephan Sokolow 2012-03-03 19:50:26 UTC

Created attachment 57992 [details] [review]
Rebased patch for more robust fallback behaviour

Here. Rebased against 2d12187926743fcde751d7b376d0300cb8b3747a.

Looking at the differences between this patch and the old one, it looks like I may have accidentally mis-ordered or duplicated one of the other two patches when preparing the old version of this one.

Time for me to experiment with StGit, I guess.

Comment 4 GitLab Migration User 2019-02-16 13:34:49 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xdg/xdg-utils/issues/56.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.