Bug 4461

Summary:

[PATCH] make XKB data location consistent, and add configure options

Product:

xorg

Reporter:

Bill Crawford <billcrawford1970>

Component:

Build/Modular

Assignee:

Daniel Stone <daniel>

Status:

RESOLVED FIXED

QA Contact:

Xorg Project Team <xorg-team>

Severity:

normal

Priority:

high

CC:

dberkholz, erik.andren, peter.hutterer

Version:

git

Keywords:

patch

Hardware:

x86 (IA32)

OS:

Linux (All)

Whiteboard:

2011BRB_Reviewed

i915 platform:

i915 features:

Bug Depends on:

4444

Bug Blocks:

Attachments:

Description	Flags
xkb locations fix	none
Better fix putting xkb data dir, bin dir and compiled output dir in kbproto.pc	none

Description Bill Crawford 2005-09-14 23:55:46 UTC

app/setxkbmap, app/xkbcomp, app/xkbevd and data/xkbdata all depend on knowing
the correct location of XKB data (which should now be /usr/share/X11/xkb by
default). Also the location of xkbcomp needs to be consistent, as some programs
look for it in .../xkb/xkbcomp, which is no longer correct. In the long run this
simply needs to be $(bindir), but should be configurable for e.g. distributions
that might need to release updates compatible with existing layouts.

This patch corrects the default locations in setxkbmap, xkbcomp and xkbevd; adds
a configure option to xkbdata; and corrects xkbdata default install location
from $(libdir) to $(datadir).

Comment 1 Eric Anholt 2005-09-15 19:10:29 UTC

The patch didn't get attached it seems.  What's up?

Comment 2 Bill Crawford 2005-09-16 04:30:10 UTC

(In reply to comment #1)
> The patch didn't get attached it seems.  What's up?

I fell asleep :) Attaching in a moment.

Comment 3 Bill Crawford 2005-09-16 04:30:51 UTC

Created attachment 3294 [details] [review]
xkb locations fix

Comment 4 Bill Crawford 2005-09-24 22:38:29 UTC

Created attachment 3395 [details] [review]
Better fix putting xkb data dir, bin dir and compiled output dir in kbproto.pc

This puts all the config in one place, and allows external packages to pick up
the XKB data location via pkg-config. Also amends xkbdata, xkbcomp, setxkbmap,
xkbevd and xorg configure.ac to use pkg-config to look up XKB paths. Paths can
be overridden by configure flags on each package, this probably isn't necessary
but since the server was allowing xkbdatadir and xkmoutputdir to be set anyway,
seems more consistent.

Comment 5 Erik Andren 2006-04-18 05:10:47 UTC

Added patch keyword

Comment 6 Adam Jackson 2006-05-19 03:31:46 UTC

-> 7.2

Comment 7 Donnie Berkholz 2006-07-07 16:58:42 UTC

I think the entire part of this patch that applies to xkbdata should be ignored,
and any necessary changes should be added to xkeyboard-config instead.

Comment 8 Daniel Stone 2006-12-16 09:31:30 UTC

i won't be doing this for 7.2.  will be done async in xk-c, then updated for 7.3.

Comment 9 Daniel Stone 2007-02-27 01:28:02 UTC

Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.

Comment 10 Adam Jackson 2007-04-08 13:36:37 UTC

Move to 7.3 tracker.

Comment 11 Eric Anholt 2007-08-31 09:56:26 UTC

While this is a fine improvement to be done, it doesn't seem to be blocker-class.

Comment 12 Peter Hutterer 2014-11-11 22:22:44 UTC

Closing this bug, afaict this is now possible through various configure options.

xkeyboard-config has --with-xkb-base
xserver has --with-xkb-bin-directory, --with-xkb-path, --with-xkb-output
xkbcomp has --with-xkb-config-root

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.